custom name for square css rule to account for #48#49
Open
gsterling wants to merge 1 commit intoEvannessa:masterfrom
Open
custom name for square css rule to account for #48#49gsterling wants to merge 1 commit intoEvannessa:masterfrom
gsterling wants to merge 1 commit intoEvannessa:masterfrom
Conversation
the square rule conflicted with the forien's quest log module now it's more unique and doesn't break the quest tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The square rule conflicted with the forien's quest log module. Now it's more unique and doesn't break the quest tracker.
This should fix #48 but the rest of the rules should probably be renamed too some time in the future.
This was the only occurence of the square rule in the module and I don't see anything out of the ordinary when clicking through your module.