Feat: Set up Pre-commit Checks for API Server#114
Merged
RobertRosca merged 14 commits intomainfrom Jan 12, 2026
Merged
Conversation
CammilleCC
requested changes
Dec 19, 2025
Member
CammilleCC
left a comment
CammilleCC
left a comment
There was a problem hiding this comment.
Tested it and works nicely, though I needed to add the pre-commit package and install via pre-commit install. Maybe you could add the package on the lint deps and supply instructions for the usage as well?
RobertRosca
force-pushed
the
feat/precommit
branch
from
530e546 to
ad4ecd8
Compare
Note that these are to be fixed later See #111
RobertRosca
force-pushed
the
feat/precommit
branch
from
ad4ecd8 to
ef6fc9e
Compare
toml requires arrays to be of a consistent type, cannot have list of str and obj
RobertRosca
added a commit
to RobertRosca/DAMNIT-web
that referenced
this pull request
Jan 13, 2026
MR: - Sets up various pre-commit hooks for the API server. - Applies formatting fixes to the code to have the checks pass. - Sprinkles in some comments to disable type checks on problematic areas, with a `TODO` next to it to remember to go back later and fix the issues Closes European-XFEL#119
RobertRosca
added a commit
to RobertRosca/DAMNIT-web
that referenced
this pull request
Jan 13, 2026
MR: - Sets up various pre-commit hooks for the API server. - Applies formatting fixes to the code to have the checks pass. - Sprinkles in some comments to disable type checks on problematic areas, with a `TODO` next to it to remember to go back later and fix the issues Closes European-XFEL#119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MR:
TODOnext to it to remember to go back later and fix the issuesCloses #119