Align with single-class responsibility and fail-fast approach

[Jakubk15]

No description provided.

[Jakubk15]

/gemini review

[gemini-code-assist]

Summary of Changes

Hello @Jakubk15, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the architecture and maintainability of the parcel locker system by refactoring the parcel dispatching mechanism. It introduces a new service to encapsulate the logic for sending parcels, thereby streamlining the GuiManager and aligning the codebase with clean code principles. The changes also enhance the robustness of deletion operations by providing more informative return values and implement a fail-fast strategy for critical path operations.

Highlights

• Refactoring GuiManager: The complex parcel dispatching logic has been extracted from the GuiManager into a new dedicated service, significantly reducing its responsibilities and improving modularity.
• Introduction of ParcelDispatchService: A new ParcelDispatchService has been created to centralize and manage all aspects of parcel dispatch, including locker capacity checks, delivery scheduling, and error handling.
• Enhanced delete Method Return Types: The delete methods in ParcelContentManager, DeliveryManager, and ItemStorageManager now return CompletableFuture<Boolean> instead of CompletableFuture<Void>, providing a clear indication of whether a record was successfully deleted.
• Fail-Fast Implementation: The parcel sending process now incorporates a fail-fast approach by checking for full lockers and successful parcel sends early, preventing unnecessary operations and providing immediate feedback.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a great step towards better code structure by extracting the parcel dispatch logic into a dedicated ParcelDispatchService. This improves separation of concerns and aligns well with clean code principles. The changes to the delete methods to return a boolean are also a positive change, making the API more expressive. My review focuses on improving the robustness of the new asynchronous logic. I've identified a couple of high-severity issues where an exception is not logged and a future's result is ignored, which could lead to silent failures and data inconsistencies. I've also included some suggestions to improve consistency and code clarity.

[gemini-code-assist]

Code Review

This pull request effectively refactors the parcel dispatching logic into a new ParcelDispatchService, which is a great improvement for separation of concerns and aligns with the Single Responsibility Principle. The changes to various delete methods to return a boolean indicating success also improve the API design by providing clearer feedback on the operation's outcome. I've identified a critical issue in the new service related to asynchronous error handling that could lead to silent failures. My review includes a comprehensive code suggestion to resolve this by properly chaining CompletableFutures, ensuring robust error handling and a better user experience.

[Copilot]

Pull request overview

This PR refactors parcel sending logic by extracting it from GuiManager into a dedicated ParcelDispatchService, improving code organization and adhering to the single responsibility principle. The changes also update several delete methods to return success indicators (Boolean) instead of Void, aligning with a fail-fast approach.

Key Changes:

• Extracted parcel dispatch logic into a new ParcelDispatchService class
• Modified delete method signatures in ItemStorageManager, DeliveryManager, and ParcelContentManager to return CompletableFuture<Boolean> for better success/failure tracking
• Refactored GuiManager to delegate parcel sending to the new service

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ParcelDispatchService.java	New service class containing parcel dispatch logic previously in GuiManager
GuiManager.java	Simplified by delegating parcel sending to ParcelDispatchService and removing unused dependencies
ItemStorageManager.java	Updated delete method to return Boolean indicating deletion success
DeliveryManager.java	Updated delete method to return Boolean indicating deletion success
ParcelContentManager.java	Updated delete method to return Boolean indicating deletion success
ParcelLockers.java	Updated dependency injection to instantiate and provide ParcelDispatchService

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.