GH-144 Add parcel fees

[Jakubk15]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Jakubk15, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive fee system for sending parcels within the plugin, leveraging the Vault economy API. It allows server administrators to configure different costs for various parcel sizes, enhancing the in-game economy and resource management. The changes include core plugin modifications for economy integration, new configuration options for fees, and user-facing messages for transaction feedback.

Highlights

• Vault Economy Integration: The plugin now integrates with the Vault API, a standard for economy management in Minecraft servers, to handle in-game currency transactions for parcel services.
• Configurable Parcel Fees: New configuration options have been introduced to allow server administrators to set distinct fees for sending small, medium, and large parcels.
• Fee Withdrawal Logic: When a player sends a parcel, the system now checks their balance and automatically withdraws the configured fee. A bypass permission (parcellockers.fee.bypass) is available to exempt players from these charges.
• User Feedback Messages: New messages have been added to inform players if they have insufficient funds to send a parcel or to confirm a successful fee withdrawal.
• Build System Updates: The build.gradle.kts file has been updated to include the VaultAPI dependency and declare Vault as a required server dependency, ensuring proper plugin loading and functionality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a fee system for sending parcels, integrating with Vault for economy management. The changes include updating the build configuration to add Vault dependencies, modifying the main plugin class to handle Vault setup, and implementing the fee logic within the ParcelServiceImpl.

My review has identified a critical issue where a constructor change was not propagated to its call site, which will cause a compilation failure. I've also pointed out a couple of medium-severity issues related to dependency declaration in Gradle and locale-sensitive string formatting that could lead to bugs in different server environments. Overall, the core logic for the fee system is well-implemented, but the identified issues should be addressed to ensure the plugin is functional and robust.