fix(site): render times as unicode instead of HTML entity#279
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
📝 WalkthroughWalkthroughTwo HTML entity icons in a comparison component are replaced with Unicode equivalents: ChangesUI Icon Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to nonZero's ✓ fix — the same JSX entity issue applies to the × (×) on the "Without BrainLayer" side, which was rendering as literal "×" text. Replace with the Unicode × character. https://claude.ai/code/session_01NmYMFxKaRteEJgx2QroV54
b152af2 to
3ad037c
Compare
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
The JSX parser wasn't decoding the ✓ and × named entities,
so they were leaking through as literal text on brainlayer.etanheyman.com.
Use the actual ✓ and × characters.
https://claude.ai/code/session_01NmYMFxKaRteEJgx2QroV54
Note
Low Risk
Low risk UI-only change that swaps an HTML entity for a Unicode character; no behavioral, data, or security impact.
Overview
The
Comparisoncomponent now renders the times icon using the literal Unicode×character instead of the×HTML entity, preventing the entity text from leaking into the UI.Reviewed by Cursor Bugbot for commit c864760. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Render times symbol as unicode character in Comparison component
Replaces the HTML entity
×with the literal×character in comparison.tsx. This ensures the symbol renders correctly regardless of HTML entity parsing context.Macroscope summarized c864760.
Summary by CodeRabbit