Support Local Scene View with Compass and OverviewMap #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Local Scene View to Compass and OverviewMap. This is mostly equivalent to the support for Scene View, but requires a separate code branch because LocalSceneView and SceneView don't have a shared ancestor with the common functionality.
For the example, I used the LocalSceneView code from the Sample Viewer.
The doc comments were updated to add LocalSceneView everywhere we had SceneView.
For OverviewMap, we had two constructors --
withMapView()andwithSceneView(). It turns out that we don't even need separate constructors. I originally thought we did, because they require different "controller" types. But all the "controller" types subclass fromGeoViewController, so they can all be treated asGeoViewController. So rather than creating a third constructorwithLocalSceneView(), I just added an unnamed constructor that handles all three types. And then I marked the other two constructors "deprecated". We might want to discuss if that's the right approach.