Fix int overflow and ignored offset/count in UnsafeOutput and UnsafeByteBufferOutput#1270
Open
JamesLove03 wants to merge 1 commit intoEsotericSoftware:masterfrom
Open
Conversation
Collaborator
|
Thanks for the PR @JamesLove03. Please provide test-cases that demonstrate these fixes. I will not merge a PR without corresponding regression tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both
UnsafeOutputandUnsafeByteBufferOutputcontain two bugs in theirsix primitive-array bulk write methods.
Bug 1 — Integer overflow → JVM crash
Byte count was computed by left-shifting
array.lengthas a 32-bitint:When
array.lengthexceeds the type's overflow threshold the shift wraps to anegative
int.writeByteswidens it to a large positivelongand passes itto
unsafe.copyMemory(), causing a fatal JVM crash.This is reachable from
DefaultArraySerializerswithout any custom code.Bug 2 — offset and count parameters silently ignored
All six methods accepted
offsetandcountbut always serialized the fullarray from element 0, this behavior is altered from these method's safe counterparts.
Fix
longbefore the shift so the byte count iscomputed correctly for large arrays.
writeBytes(Object, long, int count)to acceptlong countso thecorrected value is not truncated on the way in.
offsetandcountthrough towriteBytesin all six methods.Applied identically to both
UnsafeOutputandUnsafeByteBufferOutput.The
unsafe.copyMemory()call that provides the performance benefit isuntouched; the fix has no meaningful impact on throughput.