created the home page and the navbar component the routing work is no…#11
created the home page and the navbar component the routing work is no…#11Gmin2 wants to merge 1 commit intoEshaanAgg:mainfrom
Conversation
EshaanAgg
left a comment
EshaanAgg
left a comment
There was a problem hiding this comment.
The UI looks good but needs some changes.
| // https://astro.build/config | ||
| export default defineConfig({ | ||
| integrations: [tailwind()] | ||
|
|
| "react-icons": "^4.11.0", | ||
| "rehype-external-links": "^3.0.0", |
There was a problem hiding this comment.
Why do you need these new packages? Try using Astro Icon as much as possible.
There was a problem hiding this comment.
dont we need rehype-external-links for google fonts link in the layout.astro page
There was a problem hiding this comment.
Replace this with a .svg or .webp.
| const allOrganizations = await response.json(); | ||
|
|
||
|
|
||
|
|
||
|
|
||
| --- | ||
|
|
||
| <Layout title="LFX Mentorship Metrics"> | ||
| <main> | ||
| <ul role="list" class="grid grid-cols-4 gap-4"> | ||
| { | ||
| allOrganizations.map((org: Organization) => ( | ||
| <OrganizationCard | ||
| title={org.name} | ||
| logoUrl={org.logoUrl} | ||
| id={org.id} | ||
| /> | ||
| )) | ||
| } | ||
| </ul> | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| </main> |
There was a problem hiding this comment.
Remove all the extra newlines and format the code properly.
| <a href="/" class="relative group ml-9"> | ||
| <span class="relative z-10">Home</span> | ||
| <span class="absolute bottom-[-5px] left-0 w-full h-1 bg-blue-200 transform scale-x-0 origin-left transition-transform group-hover:scale-x-100"></span> |
There was a problem hiding this comment.
Define a NavItem component and then loop over it. It would save the repetition of the same styles.
| LFX | ||
| </div> | ||
| <div class="text-white text-[90px] font-bold leading-normal"> | ||
| Matrix |
| Matrix | ||
| </div> | ||
| <div class="relative text-[24px] leading-normal font-normal"> | ||
| LFX Matrix makes it easy to sponsor and help train the next generation of open source developers by serving key needs of the community. Invest in building a stronger and more diverse community of qualified developers and engineers. |
|
|
||
| <!-- | ||
| font-family | ||
| --> | ||
|
|
||
| <link rel="preconnect" href="https://fonts.googleapis.com"> | ||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||
| <link href="https://fonts.googleapis.com/css2?family=Lato:ital,wght@0,300;0,400;0,700;0,900;1,100;1,400;1,700;1,900&family=Plus+Jakarta+Sans:ital,wght@0,200;0,300;0,400;1,200;1,300&family=Poppins:ital,wght@0,200;1,200&family=Roboto:wght@300;400&display=swap" rel="stylesheet"> | ||
|
|
There was a problem hiding this comment.
Properly indent the code. Use Astro's VS Code extension to auto-format the code for constitency.
|
|
|
Your branch has some conflicts. Push the latest code for the frontend and backend repos, and then try to make the changes. If the error persists, please give a more descriptive description of where the error is. This screen is too general to debug the error. |
|
bhaiya the error is still there |
|
@Min2who Your branch is way behind the current progress. Please pull the latest changes for the frontend as well as the backend, install the dependencies again, and then try. It should fix most of your issues. |
2 participants
added the homepage and the navbar although the routing part is not added properly
solves issues #2