Modularise the settings and improve the loader#2049
Closed
ImFirstPlace wants to merge 3 commits intoEpix-Incorporated:masterfrom
Closed
Modularise the settings and improve the loader#2049ImFirstPlace wants to merge 3 commits intoEpix-Incorporated:masterfrom
ImFirstPlace wants to merge 3 commits intoEpix-Incorporated:masterfrom
Conversation
Closed
Contributor
|
Will check this out later |
Member
|
Guess who gave you merge conflicts |
Member
|
Check again you silly minx |
Contributor
Author
|
Hmm what am I missing? |
7a56c10 to
ddd9a4a
Compare
Contributor
Author
|
Removed a duplicate commit |
Contributor
Author
|
@Dimenpsyonal I have fixed the merge conflict |
ddd9a4a to
d5a659f
Compare
Contributor
Author
|
Continued here: #2050 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes:
NOTE: The settings structure has not changed.
Benefits of Modularising the settings:
PoF: I have tested all cases on my side (see checklist below).
Test checklist:
Screenshots: