Skip to content

Conversation

@gahxke
Copy link

@gahxke gahxke commented Dec 29, 2025

This PR makes it possible for NixOS and non-Linux users to build Adonis without running into problems with the shebang.

- This makes it possible for NixOS and non-Linux users to build Adonis without running into problems with the shebang.
@ccuser44
Copy link
Contributor

I even think sh should be used instead of bash

@ccuser44
Copy link
Contributor

For better compatibility

@gahxke
Copy link
Author

gahxke commented Dec 31, 2025

I even think sh should be used instead of bash

I guess you could use sh but

  • Bash script usually #!/bin/sh If they rely on non-standard bash features, it is highly recommended to have a #!/bin/bash shebang
  • In GNU/Linux, /bin/sh is Bash That depends on the distribution. It can also be dash or mksh on Debian for instance.
  • In FreeBSD, /bin/sh is not bash, it's the true sh. There is a lot of sh implementations. Which one is "true"? On FreeBSD, sh is based on the Almquist shell like dash or NetBSD sh. On OpenBSD, it's based on pdksh, on many commercial Unices, it's based on ksh88 (which is the basis for the Unix/POSIX sh specification). Some ksh88-based shells and bash are the only two shells that have been certified as being a Unix compliant sh implementation (when built with the right flags and in when in the right environment).
    https://unix.stackexchange.com/questions/44785/can-i-run-bash-scripts-in-freebsd-without-modifying-them

it's still a mess on non-Linux environments, although the scripts' POSIX enough (it's just a few lines) that I don't think it'd matter that much. /usr/bin/env is way better though.

@Dimenpsyonal Dimenpsyonal added the github GitHub workflows and documentation etc. label Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github GitHub workflows and documentation etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants