[os/linux]: replace linux type stubs and fix condvar ordering#624
Open
bonsthie wants to merge 2 commits intoEpicGamesExt:masterfrom
Open
[os/linux]: replace linux type stubs and fix condvar ordering#624bonsthie wants to merge 2 commits intoEpicGamesExt:masterfrom
bonsthie wants to merge 2 commits intoEpicGamesExt:masterfrom
Conversation
bonsthie
commented
Aug 27, 2025
bonsthie
commented
- Replace OS_Handle parameters with proper Mutex/RWMutex/CondVar/Semaphore/Barrier to match os_core.h declarations on Linux, so the code compiles on Linux.
- Fix os_cond_var_wait_rw_w and os_cond_var_wait_rw_r lock ordering to avoid deadlock.
- Replace OS_Handle parameters with proper Mutex/RWMutex/CondVar/Semaphore/Barrier to match os_core.h declarations on Linux, so the code compiles on Linux. - Fix os_cond_var_wait_rw_w and os_cond_var_wait_rw_r lock ordering to avoid deadlock.
mmozeiko
reviewed
Aug 27, 2025
| //////////////////////////////// | ||
| //~ rjf: Helpers | ||
|
|
||
| #include <asm-generic/errno.h> |
Collaborator
There was a problem hiding this comment.
If errno.h header is needed then it should be #include <errno.h> not <asm-generic/errno.h>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.