Ports Blender 4.0 FBX anim export#706
Open
universalconquistador wants to merge 1 commit into
Open
Conversation
mahreeoocedev01
approved these changes
Apr 11, 2024
JoshQuake
added a commit
to JoshQuake/BlenderTools
that referenced
this pull request
May 22, 2024
Ported Pull Request EpicGames#706 by universalconquistador from EpicGamesExt/BlenderTools repo
Contributor
This repo is dead. New home: https://github.com/poly-hammer/BlenderTools |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-does the
fbx_animations_dofunction by starting from the latest copy of the actual FBX exporter and then adding the changed bits I could identify. I'm not 100% sure I got each of the send2ue-specific changes, but this seems to work correctly for me so far...I marked the sections that have been changed with comments containing
send2ue, so they can be easily found next time the upstream function changes and needs to be integrated.This PR fixes issue #696, and also integrates everything else that has been added to this part of the FBX exporter, including the new numpy anim export, so hopefully this will enable the speed ups that should be coming from that.
I didn't run the unit tests (not interested in wrestling with Docker on Windows) so no guarantees there.