Llvm16 pr#23
Open
davidedelvento wants to merge 10 commits into
Open
Conversation
✅ Deploy Preview for dreamy-capybara-6a89db ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wsmoses
reviewed
Feb 3, 2024
| ``` | ||
|
|
||
| ## Performing AD Enzyme | ||
| ## Performing AD Enzyme (the gory details) |
Member
There was a problem hiding this comment.
Maybe internals? Or on the inside
wsmoses
reviewed
Feb 14, 2024
| ``` | ||
|
|
||
| ## Performing AD Enzyme | ||
| ## Performing AD Enzyme (internal details) |
Member
There was a problem hiding this comment.
perhaps call it LLVM-native rather than internal defaults?
wsmoses
reviewed
Feb 14, 2024
| @@ -138,12 +143,29 @@ For ease, we could combine the final optimization and bianry execution into one | |||
| clang output.ll -O3 -o a.exe | |||
| ``` | |||
|
|
|||
wsmoses
approved these changes
Feb 14, 2024
wsmoses
left a comment
wsmoses
left a comment
Member
There was a problem hiding this comment.
LGTM, with some minor wording changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the docs augmenting (rather than replacing) the examples for LLVM16+ as discussed at EnzymeAD/Enzyme#1462
Note that the version of Enzyme that I am using, namely
dc1c2696(a few commits afterv0.0.86) does not appear to be supporting theCache behavioroptions so I have not updated that section and I have left a comment about it in the title (perhaps not clearest, please improve that part --as any other-- as you see fit)