[EAN-Issue-2520] Added logic to validate txn caller address#10
Merged
aregng merged 1 commit intotask/issue-2529from Jan 22, 2026
Merged
[EAN-Issue-2520] Added logic to validate txn caller address#10aregng merged 1 commit intotask/issue-2529from
aregng merged 1 commit intotask/issue-2529from
Conversation
- Introduced ExecutionMode describing the context of the vm for the
transaction being executed
- Extended Handler with validate_caller() which validates caller address
based on the transaction execution mode.
- System transaction caller is expected to be VM_SIGNER reserved address
- All User/Automated transactions having any of the supra reserved as
caller will fail validation
sjoshisupra
reviewed
Dec 31, 2025
| /// Create new `CfgEnv` with default values and specified spec. | ||
| pub fn new_with_spec(spec: SPEC) -> Self { | ||
| Self { | ||
| chain_id: 1, |
There was a problem hiding this comment.
should chain_id be 1? Is this consistent with chain_id of Move VM?
Author
There was a problem hiding this comment.
This is a default implementation inherited from revm, in smr-moonshot when EVM Vm and it's context is created correct/configured chain-id is specified.
sjoshisupra
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced ExecutionMode describing the context of the vm for the transaction being executed
Extended Handler with validate_caller() which validates caller address based on the transaction execution mode.