[DON'T MERGE] Supra_container #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so-kkroy22
force-pushed
the
vm_upgrade_branch
branch
3 times, most recently
from
afeeb2a to
3f1f382
Compare
sjoshisupra
reviewed
Nov 15, 2024
| use supra_framework::system_addresses; | ||
|
|
||
| struct AddressToContainerMap has key, store { | ||
| address_container_map: SimpleMap<address, vector<u64>>, |
There was a problem hiding this comment.
Not sure why this is a map from address to vector<u64>, it is supposed to be from module address to container id. Assuming container id to be a unique sequence number, this can be a map address -> u64, or rather it can be Table<address,u64>.
| //TODO Task for Aosen: how this will be published and how can we get the address back | ||
|
|
||
| /// Add one module address to the container | ||
| public fun add_module_to_container(supra_framework: &signer, address: address, module_address: address) acquires AddressToContainerMap { |
There was a problem hiding this comment.
I believe creation of module should be up to container owner only. So add_module_to_container should not need supra_framework: &signer, it should need approval of owner, where owner could be single or multisig authority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.