security(tabapay): validate postMessage origin in WebView listener#2290
Draft
cursor[bot] wants to merge 1 commit into
Draft
security(tabapay): validate postMessage origin in WebView listener#2290cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
The TabaPay WebView installed an unrestricted window message listener that forwarded every postMessage payload to the Flutter messageHandler channel. A cross-origin frame or page could spoof payment success callbacks and trigger YAML-defined onSuccess actions with attacker-controlled token data. Restrict forwarding to messages whose origin matches the configured iframe URL and fail closed when the URL is not a valid http(s) origin. Add regression tests for the generated listener script. Co-authored-by: Sharjeel Yunus <sharjeelyunus@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/application-security-review-905b
branch
4 times, most recently
from
af2bf1a to
c88dd07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability summary
The TabaPay Connect WebView installed an unrestricted
window.addEventListener("message", …)handler that forwarded everypostMessagepayload to the FluttermessageHandlerJavaScript channel.Affected location
modules/ensemble/lib/widget/fintech/tabapayconnect.dartmodules/ensemble/lib/widget/fintech/tabapay_post_message.dartAttack path
postMessageinto the WebView window.event.datashaped like TabaPay success payloads (last4|expiration|token|zip).messageHandler→_handleTabaPayMessage→onSuccessYAML action.Severity
Medium
Fix
Restrict forwarding to messages whose
event.originmatches the configured iframe URL origin; fail closed for invalid URLs.Tests
modules/ensemble/test/tabapay_post_message_test.dart