security(ensemble): sanitize global script handler call arguments#2287
Draft
cursor[bot] wants to merge 1 commit into
Draft
security(ensemble): sanitize global script handler call arguments#2287cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Coerce untrusted handler inputs into safe JavaScript call arguments before embedding them in generated function snippets. Valid JSON from callers is passed through; raw strings are JSON-encoded to prevent breakout from deeplink, notification, and BLE handler paths. Co-authored-by: Sharjeel Yunus <sharjeelyunus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability summary
Untrusted input passed to
ScreenController.runGlobalScriptHandlerwas embedded directly into generated JavaScript asfunctionName(<argument>). Callers that forgot to JSON-encode (as BLE previously did) could allow breakout from the argument position and execute arbitrary JavaScript.Affected location
modules/ensemble/lib/screen_controller.dartmodules/ensemble/lib/framework/global_script_handler_security.dartSecurity impact
"); maliciousCode();//breaks out of the call argument and runs in the Ensemble JS interpreter contextFix approach
Add
toSafeJavaScriptCallArgument()that passes through valid JSON literals and JSON-encodes any other value before embedding in the generated snippet.Tests
modules/ensemble/test/global_script_handler_security_test.dart