Skip to content

Update script spliceai_annotation_file.py#1186

Open
dglemos wants to merge 1 commit intoEnsembl:postreleasefix/116from
dglemos:update_gene_annotation_script
Open

Update script spliceai_annotation_file.py#1186
dglemos wants to merge 1 commit intoEnsembl:postreleasefix/116from
dglemos:update_gene_annotation_script

Conversation

@dglemos
Copy link
Copy Markdown
Contributor

@dglemos dglemos commented Oct 2, 2025

No description provided.

# For other species we select the canonical transcripts and the gene name is in xref
sql_select = """
SELECT DISTINCT g.stable_id,s.name,t.seq_region_strand,t.seq_region_start,t.seq_region_end,
SELECT DISTINCT g.stable_id,g.stable_id,s.name,t.seq_region_strand,t.seq_region_start,t.seq_region_end,
Copy link
Copy Markdown
Contributor

@ainefairbrother ainefairbrother Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selection of g.stable_id occurs twice, which then affects the col indexing later on, i.e. L81 strand = row[3] and other row[x] selections

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the duplicate key is to maintain the same number of columns.

Copy link
Copy Markdown
Contributor

@ainefairbrother ainefairbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than L56 SELECT statement perhaps needs revising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants