Open
Conversation
added 4 commits
February 21, 2026 00:20
and other findings from in-person review
e987427 to
2fadd34
Compare
2fadd34 to
5870d17
Compare
5870d17 to
198bb42
Compare
Member
|
Hey @johanvo. First off all, hats off! 🚀 This looks like a GREAT addition! I have some small findings to improve this even further, let's discuss them IRL. I'm dropping them here in the PR FYI and to write out my thoughts. |
rick-nu
reviewed
Mar 9, 2026
Comment on lines
60
to
63
| awk 'BEGIN {FS = " { [#][#][ ]?"} /^([a-zA-Z_-]*:?.*)(\{ )?[#][#][ ]?/ \ | ||
| {printf "\033[33m%-34s\033[0m %s\n", $1, $2}' $0 |\ | ||
| {printf "\033[33m%-34s\033[0m %s\n", $1, $2}' "$TASKFILE_FILE" |\ | ||
| sed -E "s/[#]{2,}[ ]*/${RESET}/g" |\ | ||
| sed -E "s/function task:*/ /g" |
Member
There was a problem hiding this comment.
So I have the following output now for ./Taskfile:
❯ ./Taskfile
<banner>
=> Available tasks
Home Assistant OS
haos List all Home Assistant OS related tasks
Usage: /home/rick/Projects/FuturePortal/Server/Taskfile <task> <args>
When I run ./Taskfile haos:
❯ ./Taskfile haos
<banner>
=> Available server tasks
Home Assistant OS
start Start the VM
restart Restart the VM
shell Open Home Assistant OS shell
shutdown Stop the VM gracefully
status Show the status of the virtual machines
Home Assistant OS backup
backup Create a backup of the Home Assistant OS VM
Home Assistant OS installation
create Create the Home Assistant OS VM
auto-start Enable auto-start for the VM
edit Edit the Home Assistant OS VM configuration
remove Remove the Home Assistant OS VM and disk image
Usage: ./home-assistant-os/SubTaskfile <task> <args>
What I would love to see, and that might clarify a lot for the user:
❯ ./Taskfile haos
<banner>
=> Available server tasks
Home Assistant OS
haos start Start the VM
haos restart Restart the VM
haos shell Open Home Assistant OS shell
haos shutdown Stop the VM gracefully
haos status Show the status of the virtual machines
Home Assistant OS backup
haos backup Create a backup of the Home Assistant OS VM
Home Assistant OS installation
haos create Create the Home Assistant OS VM
haos auto-start Enable auto-start for the VM
haos edit Edit the Home Assistant OS VM configuration
haos remove Remove the Home Assistant OS VM and disk image
Usage: ./Taskfile ${YELLOW}haos <task>${RESET} <args>
Or maybe something like a header:
❯ ./Taskfle haos
<banner>
=> Showing sub-tasks for ${YELLOW}haos${RESET}
Home Assistant OS
start Start the VM
restart Restart the VM
shell Open Home Assistant OS shell
shutdown Stop the VM gracefully
status Show the status of the virtual machines
Home Assistant OS backup
backup Create a backup of the Home Assistant OS VM
Home Assistant OS installation
create Create the Home Assistant OS VM
auto-start Enable auto-start for the VM
edit Edit the Home Assistant OS VM configuration
remove Remove the Home Assistant OS VM and disk image
Usage: ./Taskfile ${YELLOW}haos <task>${RESET} <args>
The current output is not clear enough to me
rick-nu
reviewed
Mar 9, 2026
README.md
Outdated
Comment on lines
+130
to
+131
| # Without this, you cannot run `./Taskfile foo` or `./Taskfile foo help` | ||
| function task:_help { ## Show all available tasks |
Member
There was a problem hiding this comment.
Suggested change
| # Without this, you cannot run `./Taskfile foo` or `./Taskfile foo help` | |
| function task:_help { ## Show all available tasks | |
| # ========================================================= | |
| # SubTaskfile helper | |
| # ========================================================= | |
| function task:_help { # Show all available tasks |
Member
|
I would love to see a generator option |
ie: which should be used in the final Subtaskfile and which are only clarifications in the context of the README
Also use env vars instead of function params to influence task:help output
* Add subtaskfile setup in the generator * Add subtaskfile content * Style sub pages for docs * Improve colors * Finalize new design * Reset README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
task:helpin the Taskfile-generator template so it can accept a filename as parameter $1 (it defaults to $0, consistent with previous behavior)Why
By documenting ways to expand upon the base Taskfile concept (for advanced use-cases) we promote a consistent ecosystem and build upon shared experience, making Taskfiles more useful for everyone.
Specifically: in cases where you have groups of tasks that are only useful in certain contexts, SubTaskfiles allow you to keep them logically grouped with a minimum of overhead, no weird syntax and all the general niceties of a regular Taskfile (its-just-bash, simple
helpoutput, access to general usability functions, etc.Example of minimal SubTaskfile setup
Relevant parts of ./Taskfile
Full contents of ./path/to/subtaskfile/SubTaskfile
ToDo