Skip to content

Chore/lint#22

Merged
urabexon merged 6 commits into
mainfrom
chore/lint
Sep 11, 2025
Merged

Chore/lint#22
urabexon merged 6 commits into
mainfrom
chore/lint

Conversation

@urabexon

@urabexon urabexon commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

対応完了✅

やったこと

  • Lint / Prettier設定
  • プルリク作成したら、テンプレが本文に入るようにした!

Actionsは環境的に動作できない可能性があったので、削除しました。

@urabexon urabexon requested a review from Copilot September 11, 2025 13:25
@urabexon urabexon self-assigned this Sep 11, 2025
@vercel

vercel Bot commented Sep 11, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
team-8-app Error Error Sep 11, 2025 1:49pm

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets up linting, formatting, and CI automation for the codebase. It configures ESLint, Prettier, and TypeScript checks that will run automatically on pull requests, eliminating the need for manual linting commands.

  • Added comprehensive development tooling with ESLint, Prettier, and TypeScript configuration
  • Implemented GitHub Actions CI workflow to automatically check code quality on pull requests
  • Updated existing files to conform to new formatting standards (single quotes, import sorting)

Reviewed Changes

Copilot reviewed 8 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Added lint, format, and type-check scripts plus related dev dependencies
.prettierrc Configured code formatting rules and import sorting
.eslintrc.json Set up ESLint rules for Next.js with unused imports checking
.github/workflows/ci.yml Created CI workflow for automated quality checks
.github/pull_request_template.md Added PR template with quality checklist
.npmrc Configured pnpm settings for dependency management
next.config.ts Reformatted to match new Prettier rules
middleware.ts Applied formatting changes and updated matcher pattern

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/ci.yml Outdated

- uses: pnpm/action-setup@v4
with:
version: 9

Copilot AI Sep 11, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pnpm version should be pinned to match the packageManager field in package.json (9.0.0) for consistency, or use a more specific version like 9.12.0.

Suggested change
version: 9
version: 9.0.0

Copilot uses AI. Check for mistakes.
@urabexon

Copy link
Copy Markdown
Contributor Author
  • Tailwind未導入のため、Vercelのデプロイエラー出てる(なぎささんのと合わせれば直るはず)

@urabexon

urabexon commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

恐らくCIが回らないのはリポジトリオーナー(Hackathon主催者側)の利用枠制限で止められる可能性が高そう。
不要コードになるのでci.ymlは削除する。

@urabexon

Copy link
Copy Markdown
Contributor Author
  • Tailwind導入すれば直るエラーなので、今は速度重視でマージします

@urabexon urabexon requested a review from Copilot September 11, 2025 13:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 10 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread package.json
"format:check": "prettier --check .",
"type-check": "tsc --noEmit",
"clean": "rm -rf .next out",
"postinstall": "pnpm -s dlx supabase gen types typescript --project-id $SUPABASE_PROJECT_ID > utils/supabase/database.types.ts || echo 'skip supabase typegen (SUPABASE_PROJECT_ID not set)'"

Copilot AI Sep 11, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The postinstall script uses an environment variable ($SUPABASE_PROJECT_ID) without validation and writes to a file. This could potentially expose sensitive project information or create security vulnerabilities if the environment variable contains malicious content.

Suggested change
"postinstall": "pnpm -s dlx supabase gen types typescript --project-id $SUPABASE_PROJECT_ID > utils/supabase/database.types.ts || echo 'skip supabase typegen (SUPABASE_PROJECT_ID not set)'"
"postinstall": "node scripts/generate-supabase-types.js"

Copilot uses AI. Check for mistakes.
@urabexon urabexon merged commit 7755b64 into main Sep 11, 2025
1 of 2 checks passed
@urabexon urabexon deleted the chore/lint branch September 11, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants