Add region_id to ProcessFlow#1314
Draft
tsmbland wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## flows_map #1314 +/- ##
=============================================
+ Coverage 89.70% 89.71% +0.01%
=============================================
Files 58 58
Lines 8481 8492 +11
Branches 8481 8492 +11
=============================================
+ Hits 7608 7619 +11
Misses 566 566
Partials 307 307 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #1311, this adds a
region_idfield toProcessFlowso we can (in theory) represent flows between regions. More still to do (probably in separate PRs):ProcessFlowsMapis keyed byCommodityID, but we'll probably need to key this by(CommodityID, RegionID)to allow for multiple entries for the same commodity (i.e. out of one region and into another), or store as a vecIt's quite fiddly though and I'm a bit uneasy about this. We need to switch all flow-related stuff that's currently relying on the asset's region to rely instead on the
ProcessFlowregion, but there's no compiler safety to protect against mistakes so will require a lot of care.