Enable usage of the ERA5 data set in the wind_power_timeseries module#8
Enable usage of the ERA5 data set in the wind_power_timeseries module#8
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables support for the ERA5 dataset in the wind power timeseries functionality, expanding geographic coverage beyond the NORA3 domain (e.g., to include Spain). The changes add a new source parameter to allow users to choose between "NORA3" and "ERA5" data sources, with "NORA3" remaining the default.
Key changes:
- Updated the
wind_power_timeseriessubmodule to a version that supports ERA5 data - Added a
sourceparameter to theWindPowerfunction with "NORA3" as the default value - Cleaned up redundant conda initialization commands in the CI workflow
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| submodules/wind_power_timeseries | Updated submodule commit to version with ERA5 support |
| src/datastructures.jl | Added source parameter to WindPower function for data source selection |
| .github/actions/before-script/action.yml | Removed duplicate conda initialization commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JulStraus
left a comment
JulStraus
left a comment
There was a problem hiding this comment.
Not too much to comment on. Additional input to python, additional input to the constructor. Seems reasonable.
There was a problem hiding this comment.
Why are these two lines removed? No longer required?
There was a problem hiding this comment.
They were redundant to begin with apparently.
This PR enables the usage of ERA5 data set (e.g. enables usage in Spain which is outside the NORA3 domain) which has now been enabled in the sample function of
wind_power_timeseriesmodule.