Conversation
added 6 commits
December 17, 2025 12:27
…"data"-menu by including the `id` field in parantheses. Also, improve the info-box.
… Introduced module names as intermediate `Dict`s in the `structures` field of `descriptive_names` (this is a breaking change).
…es (through a `.geojson` file location provided by the keyword argument `map_boundary_file` in the `GUI`-function).
dqpinel
reviewed
Dec 17, 2025
Collaborator
dqpinel
left a comment
dqpinel
left a comment
There was a problem hiding this comment.
Some minor changes to be made in the documentation otherwise ok.
| @@ -0,0 +1,30 @@ | |||
| # [Improve performance](@id how_to-improve_performance) | |||
|
|
|||
| Due to the just-in-time (JIT) compilation of Julia, the instantiation of the `EnergyModelsGUI` window takes some time (but reopening the windo will take less time) and this also includes interactive features in the GUI (plotting a plot over `OperationalPeriod`s is a lot faster compared to the first plot). | |||
Collaborator
There was a problem hiding this comment.
Some general comments:
Maybe split the sentence before the "and this also includes"
"plotting a plot" is redundant
I don't really understand what you mean with the sentence in paentheses: what is the first plot?
use "faster than" rather than "faster coompared to"
| const TS = TimeStruct | ||
|
|
||
| """ | ||
| All-in-one-case: combines all nodes from the main EMX packages. |
Collaborator
There was a problem hiding this comment.
Should you specify the version of all EMX packages used in the example to make it easier to keep track of what is missing or outdated for future maintenance? I can imagine this gets forgotten while doing other changes to the package and keeping track of what needs to be updated being difficult.
dqpinel
reviewed
Dec 17, 2025
dqpinel
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more descriptive names for more EMX packages and adds a comprehensive test to check if all nodes contains descriptions. The idea is to have a fallback description for all the main EMX packages which can be overwritten in three different ways as explained by the docs.
The example includes EnergyModelsGeography in combindation with EnergyModelsInvestments at the top level:
and a comprehensive collection of nodes compiled by the examples of EMX packages:
For completeness, the second area (Coal area) can be illustrated by the following