Conversation
added 6 commits
December 16, 2025 11:02
…"data"-menu by including the `id` field in parantheses. Also, improve the info-box.
… Introduced module names as intermediate `Dict`s in the `structures` field of `descriptive_names` (this is a breaking change).
…es (through a `.geojson` file location provided by the keyword argument `map_boundary_file` in the `GUI`-function).
There was a problem hiding this comment.
Pull request overview
This PR enhances the handling of descriptive_names with a breaking change that introduces module names as intermediate dictionaries in the structures field. Key improvements include adding missing descriptive names for several variables, expanding export format support for the topology axis, and enabling custom boundary background maps.
- Added missing descriptive names for
emissions_link,link_opex_var,link_opex_fixed, andemissions_trans - Enabled exporting topology axis to additional image formats (bmp, tif, tiff, jpg, jpeg, png)
- Restructured
descriptive_names[:structures]to use module names as intermediate dictionaries for better package robustness
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/test_interactivity.jl | Updated test expectations to include new export formats for Topo axis |
| test/test_descriptive_names.jl | Updated tests to accommodate new module-based structure hierarchy and added comprehensive coverage tests |
| src/utils_gen/utils.jl | Enhanced error handling in get_nested_value and refactored inherit_descriptive_names_from_supertypes! to support module-based structure |
| src/utils_gen/structures_utils.jl | Removed unused loaded() function |
| src/utils_gen/export_utils.jl | Added support for exporting Topo axis to multiple image formats |
| src/utils_GUI/results_axis_utils.jl | Updated key string generation to include parent module in path |
| src/utils_GUI/GUI_utils.jl | Refactored descriptive names handling, replacing update_descriptive_names! with create_descriptive_names and added get_descriptive_names functions |
| src/setup_topology.jl | Updated docstring to reflect kwargs support |
| src/setup_GUI.jl | Added map_boundary_file parameter and refactored boundary map rendering to support custom GeoJSON files |
| src/descriptive_names.yml | Reorganized structure to group descriptive names by module and added missing variable descriptions |
| src/EnergyModelsGUI.jl | Exported new public functions create_descriptive_names and get_descriptive_names |
| examples/generate_examples.jl | Removed obsolete comments from example data |
| docs/src/library/public.md | Added documentation entries for new exported functions |
| NEWS.md | Added release notes for version 0.6.0 |
Comments suppressed due to low confidence (1)
test/test_descriptive_names.jl:1
- This logic for extending selection when data is a Resource appears misplaced in the test file diff. This code should be in the source files, not in test changes. Verify this logic is in the correct location.
const EMB = EnergyModelsBase
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dqpinel
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the handilng of
descriptive_names(including a breaking change). It also provides more export options and enables custom boundary background map specifications. In particular:emissions_link,link_opex_var,link_opex_fixedandemissions_trans..geojsonfile location provided by the keyword argumentmap_boundary_filein theGUI-function).descriptive_namesto be more robust to available packages. Introduced module names as intermediateDicts in thestructuresfield ofdescriptive_names(this is a breaking change).