🧹 [code health improvement description] Remove unused EnapterDataMapper import from http init#22
Conversation
…er import from http init 🎯 **What:** Removed the unused `EnapterDataMapper` import from `src/enapter_mcp_server/http/__init__.py`. 💡 **Why:** `EnapterDataMapper` was not needed as part of the public API of the `http` package, since it is an internal implementation detail and testing class, but `EnapterAPI` acts as the main public interface for this module. Removing unused imports improves maintainability. ✅ **Verification:** Updated the unit tests for `EnapterDataMapper` and `EnapterAPI` to import `EnapterDataMapper` directly from `enapter_mcp_server.http.enapter_data_mapper`. Ran tests and verified that logic still holds and the file was modified properly. ✨ **Result:** Cleaned up unused imports in the module initialization, keeping only explicitly public models in `__init__.py`. Co-authored-by: rnovatorov <20299819+rnovatorov@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Removed the unused
EnapterDataMapperimport fromsrc/enapter_mcp_server/http/__init__.py.💡 Why:
EnapterDataMapperwas not needed as part of the public API of thehttppackage, since it is an internal implementation detail and testing class, butEnapterAPIacts as the main public interface for this module. Removing unused imports improves maintainability.✅ Verification: Updated the unit tests for
EnapterDataMapperandEnapterAPIto importEnapterDataMapperdirectly fromenapter_mcp_server.http.enapter_data_mapper. Ran tests and verified that logic still holds and the file was modified properly.✨ Result: Cleaned up unused imports in the module initialization, keeping only explicitly public models in
__init__.py.PR created automatically by Jules for task 15486221074562432445 started by @rnovatorov