fix(commands-plugin): ensure currentCommand is updated correctly on c…#49
Open
guuhuu wants to merge 2 commits into
Open
fix(commands-plugin): ensure currentCommand is updated correctly on c…#49guuhuu wants to merge 2 commits into
guuhuu wants to merge 2 commits into
Conversation
…hange Applied a hacky workaround because Grafana does us a disservice with its automatic deep merging of old and new panel state. This "helpful" feature has no opt-out and causes stale argument values to persist when switching between commands. The workaround sets currentCommand to undefined first, then applies the actual value in the next frame via requestAnimationFrame, forcing Grafana to treat it as a fresh object rather than merging it with the previous state. A clean solution would require rewriting the plugin's state management.
Author
Member
|
Just for the record: there's a bug in the current implementation that prevents us from merging this as is. If you select one device and then you select another device, the commands from both devices get mixed in a single list: 
@guuhuu, have you had any success fixing the bug? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied a hacky workaround because Grafana does us a disservice with its automatic deep merging of old and new panel state.
This "helpful" feature has no opt-out and causes stale argument values to persist when switching between commands.
The workaround sets currentCommand to undefined first, then applies the actual value in the next frame via requestAnimationFrame, forcing Grafana to treat it as a fresh object rather than merging it with the previous state.
A clean solution would require rewriting the plugin's state management.
Fixes #48
Disclaimer: everything written above might be complete nonsense due to my limited understanding of Grafana internals. If you know a better way, please don't judge me too harshly.