Fix variant-switch image caching (issue #79)#82
Merged
Conversation
…omPackRelativePath ImageReference.FromPackRelativePath now takes Sessions.PackageInstance instead of IGamePackage. Each call site derives pi from this.OwnerState (or the already-available state parameter) rather than going through the ambient PackageInstanceForPackageResolver, which used FirstOrDefault and ignored variant — causing images to be stamped with the previous variant's PackageInstance when switching variants. Fixes #79. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageReference.FromPackRelativePathnow acceptsSessions.PackageInstancedirectly instead ofIGamePackagepifromthis.OwnerState(or the already-availablestateparameter) — no method signature changes in the parse chainPackageInstanceForPackageResolverlookup, which usedFirstOrDefaultand ignored variant identity, causing allImageReferences created during a variant-B load to be stamped with variant-A'sPackageInstanceRoot cause
ActiveSession.PackageInstanceForPackageResolverresolved a PI by matching only onIGamePackagereference (FirstOrDefault). When variant B was loaded for a pack that already had variant A's PI registered, every newImageReferencewas stamped with PI_A — so the image cache for the new variant was never consulted and images were always one variant behind.Test plan
Fixes #79.
🤖 Generated with Claude Code