fix: split input sequence correctly and enable using kv_dim#116
Open
richardk53 wants to merge 1 commit intomainfrom
Open
fix: split input sequence correctly and enable using kv_dim#116richardk53 wants to merge 1 commit intomainfrom
richardk53 wants to merge 1 commit intomainfrom
Conversation
… parts for kv and 6 parts for q instead of 8 same-sized parts (which is wrong if kv_dim is different)
richardk53
requested review from
HennerM,
MauritsBleeker and
Ndles
as code owners
|
Collaborator
MauritsBleeker
left a comment
MauritsBleeker
left a comment
There was a problem hiding this comment.
Can/should we add a test for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, kv_dim has not been enabled together with modulation and instead thrown an assert.
This is because the input sequence is simply split into 8 equally sized parts, which is incorrect if kv_dim differs.
This PR fixes this.
I have read the CLA Document and I hereby sign the CLA