Camera alpha scale bug #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinRobomaze
force-pushed
the
Camera_alphaScale_error
branch
from
b59b379 to
3232e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When using this library to interface usb2fir on Raspberry Pi 3, I found out that alphaScale value is not correctly retrieved from the board. I suppose that i is some kind of type overflow, because the alphaScale value is 0. After some investigation I found out that requesting raw data is successful, so the error has to be somewhere in alphaScale calculation. I specified the data type to int in line 128 -
alphaScale = int((eepromdata[0x20] >> 12) + 30)and the alphaScale value has been retrieved and calculated correctly ever since.