Optimize puffin_egui::ProfilerUi::show_frame_list#241
Open
vdrn wants to merge 1 commit intoEmbarkStudios:mainfrom
Open
Optimize puffin_egui::ProfilerUi::show_frame_list#241vdrn wants to merge 1 commit intoEmbarkStudios:mainfrom
puffin_egui::ProfilerUi::show_frame_list#241vdrn wants to merge 1 commit intoEmbarkStudios:mainfrom
Conversation
If there are no gaps in the frame list, we can calculate the subslice of visible frames and avoid iterating through all frames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are no gaps in the frame list, we can calculate the subslice of visible frames and avoid iterating through all frames.
Checklist
Description of Changes
show_frame_listscales poorly because it always iterates through all frames.When there are no gaps in the frame list, we can calculate the subslice of visible frames and just iterate through them.
By my measurements, for
35 000frames, this function takes about0.5ms.With this pull request, when there are no gaps in the frame list, it runs in constant
0.015ms.AFAIK, gaps only happen when the user calls
new_framewithout having any scopes. In that case we can fall back to current behavior.Related Issues
none