Add a pending frame list to GlobalFrameView#163
Open
Zoxc wants to merge 1 commit intoEmbarkStudios:mainfrom
Open
Add a pending frame list to GlobalFrameView#163Zoxc wants to merge 1 commit intoEmbarkStudios:mainfrom
GlobalFrameView#163Zoxc wants to merge 1 commit intoEmbarkStudios:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a pending frame list to
GlobalFrameView. It's used if the lock for theFrameViewis not available at the moment. This may happen ifpuffin_eguiis rendering whilenew_frameis called on a different thread. In that case, this change prevents thepuffin_eguifrom blocking the other thread.puffin_eguialso currently deadlocks as it holds the lock for theFrameViewwhile also having profiling scopes, making a cycle with theGlobalProfiler. This change removes that deadlock.