Trim comments in diff copy code#120
Open
Zeus-Deus wants to merge 2 commits into
Open
Conversation
The diff viewer is virtualized, so selecting all and copying only put the handful of rendered rows on the clipboard instead of the full file. Serialize the whole diff from the parsed model and intercept the copy event at the document level (the diff renders into shadow DOM, so the copy event never reaches the viewport element). Cmd/Ctrl+A inside the viewport arms the gesture; the next copy then writes the complete diff. The existing Copy button now uses the same serialized text.
Cut the explanatory comments down to one line per function to match the rest of these files. Follow-up to the select-all copy fix review.
github-actions
Bot
added
size:L
vouch:unvouched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #116.
Cleans up the explanatory comments from that PR — one short line per function instead of the longer blocks, to match how the rest of these files are written. No behavior change, comments only.