Open
Conversation
tbodt
commented
Nov 25, 2024
tbodt
commented
- firefox needs the script in background.scripts instead of background.service_worker
- onMessage listener doesn't seem to work with an async function on firefox
- setting variables with "var" at the bottom of a script actually overrides the variable for the whole script shadowing the version in the window object (this is known as "hoisting")
- firefox extension downloads API doesn't accept data urls (https://bugzilla.mozilla.org/show_bug.cgi?id=1933304) so use blobs instead
- firefox needs the script in background.scripts instead of background.service_worker - onMessage listener doesn't seem to work with an async function on firefox - setting variables with "var" at the bottom of a script actually overrides the variable for the whole script shadowing the version in the window object (this is known as "hoisting") - firefox extension downloads API doesn't accept data urls (https://bugzilla.mozilla.org/show_bug.cgi?id=1933304) so use blobs instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.