Fix HUD rerenders on Hytale 0.5.1#38
Open
Janiel777 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HyUI 0.9.7 - Hytale 0.5.1 HUD rerender follow-up
While testing
v0.9.7 - Complete Build Change, 0.5.1 support?against Hytale 0.5.1, I found one remaining HUD-specific runtime issue.The original
CustomUIHud(PlayerRef)crash is fixed by the 0.5.1 changes, and custom pages still render and interact correctly.The remaining issue is that custom HUDs render their first frame, but later updates do not visually refresh on the client.
Runtime comparison
Before this fix
The HUD is created and the first frame is visible, but the countdown/progress text stays frozen. The game logic continues running server-side.
After this fix
With commit
1cc546b, the same HUD flow refreshes normally after the initial render.What caused it
This seems to come from the new native
HudManagerbehavior in Hytale 0.5.1.The new API stores custom HUDs by key. In
HudManager.addCustomHud(...), if the HUD currently registered for that key is the same object instance, the method returns early.So the flow became:
That means the first render works, but later full rerenders can be skipped before any updated HUD commands reach the client.
Fixes #39