feat(bags): Nest by Expansion in All Items view#320
Open
liamcooper wants to merge 1 commit into
Open
Conversation
Add a default-off "Nest by Expansion" option under Bags > EXTRAS. When enabled, the All Items inventory view indents items under per-expansion sub-headers within each category (and merged groups), using item expansion metadata from the client API. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional Nest by Expansion mode for the All Items bag view. When enabled, each sidebar category (and merged category groups) shows its items under indented expansion sub-headers (e.g. Midnight, Dragonflight, Wrath of the Lich King), using
C_Item.GetItemInfoexpansion metadata. A sub-header is shown for every expansion represented in that category, including when only one expansion is present. Uncached or ambiguous items are grouped under Unknown.The setting lives under EllesmereUI → Bags → EXTRAS, paired on the same row as Show Pinned & Recent Tips, and defaults to off.
Screenshots
All Items (expansion nesting enabled)
Bags settings
Implementation notes
EllesmereUIBags.lua: expansion id/label helpers, bucket builder, sub-header pool,RenderSectionpath for All Items when the option is on.EUI_Bags_Options.lua: toggle UI and refresh on change..github/pr-screenshots/for stable image URLs in the description.Testing
/reloadafter changing the option updates the bag grid.