Docker-compose definition by ElevnLi · Pull Request #3 · ElevnLi/leaf

ElevnLi · 2021-12-10T06:14:47Z

db and ui are working in this dev version, despite that the very long time ui container takes to start.

ElevnLi · 2021-12-10T06:17:01Z

Api server can be started but will stop after sometime and shows the following error:

leaf_api_demo | /usr/share/dotnet/sdk/3.1.415/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.DefaultItems.targets(151,5): warning NETSDK1080: A PackageReference to Microsoft.AspNetCore.App is not necessary when targeting .NET Core 3.0 or higher. If Microsoft.NET.Sdk.Web is used, the shared framework will be referenced automatically. Otherwise, the PackageReference should be replaced with a FrameworkReference. [/app/API/API.csproj]
leaf_api_demo | {"Timestamp":"2021-12-10T06:08:48.4204198+00:00","Level":"Information","MessageTemplate":"Starting Leaf's API v{Version}","Properties":{"Version":"3.9.1.0"}}
leaf_api_demo | {"Timestamp":"2021-12-10T06:08:49.4050657+00:00","Level":"Fatal","MessageTemplate":"UNSECURED authentication detected, Leaf is not secured by authentication!","Properties":{"SourceContext":"API.Startup"}}
leaf_api_demo | {"Timestamp":"2021-12-10T06:08:49.4313824+00:00","Level":"Fatal","MessageTemplate":"UNSECURED authorization detected, Leaf is not secured by authorization!","Properties":{"SourceContext":"API.Startup"}}
leaf_api_demo | {"Timestamp":"2021-12-10T06:08:49.5036543+00:00","Level":"Fatal","MessageTemplate":"API terminated unexpectedly","Exception":"Model.Options.LeafConfigurationException: LEAF_JWT_KEY_PW environment variable is missing\n   at API.Options.StartupExtensions.GetByProxy(IConfiguration configuration, String key) in /app/API/Options/StartupExtensions.Options.cs:line 92\n   at API.Options.StartupExtensions.ConfigureJwtOptions(IServiceCollection services, IConfiguration config) in /app/API/Options/StartupExtensions.Options.cs:line 135\n   at API.Options.StartupExtensions.ConfigureLeafOptions(IServiceCollection services, IConfiguration configuration, IHostingEnvironment environment) in /app/API/Options/StartupExtensions.Options.cs:line 69\n   at API.Startup.ConfigureServices(IServiceCollection services) in /app/API/Startup.cs:line 34\n   at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)\n   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)\n   at Microsoft.AspNetCore.Hosting.ConfigureServicesBuilder.InvokeCore(Object instance, IServiceCollection services)\n   at Microsoft.AspNetCore.Hosting.ConfigureServicesBuilder.<>c__DisplayClass9_0.<Invoke>g__Startup|0(IServiceCollection serviceCollection)\n   at Microsoft.AspNetCore.Hosting.StartupLoader.ConfigureServicesDelegateBuilder`1.<>c__DisplayClass15_0.<BuildStartupServicesFilterPipeline>g__RunPipeline|0(IServiceCollection services)\n   at Microsoft.AspNetCore.Hosting.ConfigureServicesBuilder.Invoke(Object instance, IServiceCollection services)\n   at Microsoft.AspNetCore.Hosting.ConfigureServicesBuilder.<>c__DisplayClass8_0.<Build>b__0(IServiceCollection services)\n   at Microsoft.AspNetCore.Hosting.StartupLoader.ConfigureServicesDelegateBuilder`1.<>c__DisplayClass14_0.<ConfigureServices>g__ConfigureServicesWithContainerConfiguration|0(IServiceCollection services)\n   at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.ConfigureServices(IServiceCollection services)\n   at Microsoft.AspNetCore.Hosting.WebHost.EnsureApplicationServices()\n   at Microsoft.AspNetCore.Hosting.WebHost.Initialize()\n   at Microsoft.AspNetCore.Hosting.WebHostBuilder.Build()\n   at API.Program.Main(String[] args) in /app/API/Program.cs:line 47"}
leaf_api_demo exited with code 1

@ablachair Can you have a look? It is more like a JWT key missing error, but I did add volumes and copied the keys into the container.

ElevnLi · 2021-12-10T06:21:01Z

This should be more readable

ElevnLi · 2021-12-10T07:26:51Z

jnothman · 2021-12-13T03:18:18Z

+      - ./server:/app
+      - server-log:/logs
+    environment:
+      - LEAF_APP_DB=db,1433;Database=LeafDB;uid=sa;Password=Th3PA55--8zz


It looks like something in parsing this env var is splitting on =... You might want to run the container with bash to confirm the env vars.

…ompose

ElevnLi · 2021-12-13T07:35:53Z

temporary readme:
put your keys directory under root
and run docker-compose -f docker-compose-dev.yml up

jnothman · 2021-12-14T12:36:18Z

+  server:
+    build: ./server
+    image: leaf_api
+    container_name: leaf_api_demo
+    ports:
+      - 5001:5001
+    volumes:
+      - ./server/keys:/.keys
+      - ./server:/app
+      - server-log:/logs
+    environment:
+      LEAF_APP_DB: "Server=db,1433;Database=LeafDB;uid=sa;Password=Th3PA55--8zz"
+      LEAF_CLIN_DB: "Server=db,1433;Database=TestDB;uid=sa;Password=Th3PA55--8zz"
+      LEAF_JWT_KEY_PW: "password"
+    networks:
+      - leaf
+    depends_on:
+      - db


Suggested change

server:

build: ./server

image: leaf_api

container_name: leaf_api_demo

ports:

- 5001:5001

volumes:

- ./server/keys:/.keys

- ./server:/app

- server-log:/logs

environment:

LEAF_APP_DB: "Server=db,1433;Database=LeafDB;uid=sa;Password=Th3PA55--8zz"

LEAF_CLIN_DB: "Server=db,1433;Database=TestDB;uid=sa;Password=Th3PA55--8zz"

LEAF_JWT_KEY_PW: "password"

networks:

- leaf

depends_on:

- db

db:

extends:

file: docker-compose.yml

service: server

volumes:

- ./server/keys:/.keys

- ./server:/app

services with 'depends_on' cannot be extended

jnothman · 2021-12-14T12:37:21Z

+  ui-client:
+    build:
+      context: ./ui-client
+      dockerfile: Dockerfile-dev
+    container_name: leaf_ui
+    ports:
+      - 3000:3000
+    volumes:
+      - ./ui-client:/app
+    networks:
+      - leaf
+    stdin_open: true
+    depends_on:
+      - db
+      - server


This one we might define without extends? Or we could use extends if we serve both dev and prod versions on port 3000

services with 'depends_on' cannot be extended

jnothman

This is looking good!

jnothman · 2021-12-23T02:12:13Z

+    environment:
+      - LEAF_APP_DB=${LEAF_APP_DB}
+      - LEAF_CLIN_DB=${LEAF_CLIN_DB}
+      - LEAF_JWT_KEY_PW=${LEAF_JWT_KEY_PW}
+      - UnsecuredIsAdmin=${UnsecuredIsAdminDev}
+    networks:
+      - leaf
+    depends_on:
+      - db


Do we need this all with extends?

"services with 'depends_on' cannot be extended"

Yes, they will need to be in a separate "common services" file.

dev version

f277bf6

add env variables

b67dad6

jnothman reviewed Dec 13, 2021

View reviewed changes

ElevnLi added 3 commits December 13, 2021 17:22

fixes to make it work on Monterey

242f292

Merge branch 'usyd-fix' of github.com:ElevnLi/leaf into usyd-docker-c…

7208798

…ompose

This is a working dev version

a99f4ad

ElevnLi added 3 commits December 14, 2021 17:51

try prod version with nginx

fc23db8

add slash back

f737d8b

the frontend is working now with nginx

f6d1d03

jnothman reviewed Dec 14, 2021

View reviewed changes

ElevnLi added 4 commits December 16, 2021 12:10

change resolver and proxy

4a7115e

fix the encoding issue of .net

e465c3c

remove server docker ignore

b2d75ec

remove the user thing

71a658f

jnothman changed the title ~~dev version~~ Docker-compose definition Dec 17, 2021

ElevnLi added 5 commits December 20, 2021 13:43

remove testdb for demo

02b0d98

still add testDB but no test data from leaf

e9fbd91

Add flag to control admin

247cf00

clean docker-compose

9338038

clean docker-compose-dev

cc96f2b

jnothman reviewed Dec 23, 2021

View reviewed changes

ElevnLi added 2 commits January 10, 2022 13:14

add always restart for prod

2501eea

remove docker-compose for dev

3707fde

Conversation

ElevnLi commented Dec 10, 2021

Uh oh!

ElevnLi commented Dec 10, 2021

Uh oh!

ElevnLi commented Dec 10, 2021

Uh oh!

ElevnLi commented Dec 10, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ElevnLi commented Dec 13, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jnothman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants