Merge pull request #31 from tebeco/removing_async_void

robertmuehsig · web-flow · commit 9ed5738cac38 · 2017-11-04T22:38:21.000+01:00
Should never use async void
diff --git a/README.md b/README.md
@@ -45,7 +45,7 @@ public static IWebHost BuildWebHost(string[] args)
 Open the Electron Window in the Startup.cs file: 
 
 ```csharp
-public async void Configure(IApplicationBuilder app, IHostingEnvironment env)
+public void Configure(IApplicationBuilder app, IHostingEnvironment env)
 {
     if (env.IsDevelopment())
     {
@@ -67,7 +67,7 @@ public async void Configure(IApplicationBuilder app, IHostingEnvironment env)
     });
 
     // Open the Electron-Window here
-    await Electron.WindowManager.CreateWindowAsync();
+    Task.Run(async () => await Electron.WindowManager.CreateWindowAsync());
 }
 ```
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public static IWebHost BuildWebHost(string[] args)`
`45`	`45`	`Open the Electron Window in the Startup.cs file:`
`46`	`46`
`47`	`47`	```csharp
`48`		`-public async void Configure(IApplicationBuilder app, IHostingEnvironment env)`
	`48`	`+public void Configure(IApplicationBuilder app, IHostingEnvironment env)`
`49`	`49`	`{`
`50`	`50`	`if (env.IsDevelopment())`
`51`	`51`	`{`
`@@ -67,7 +67,7 @@ public async void Configure(IApplicationBuilder app, IHostingEnvironment env)`
`67`	`67`	`});`
`68`	`68`
`69`	`69`	`// Open the Electron-Window here`
`70`		`- await Electron.WindowManager.CreateWindowAsync();`
	`70`	`+ Task.Run(async () => await Electron.WindowManager.CreateWindowAsync());`
`71`	`71`	`}`
`72`	`72`	```
`73`	`73`