Should never use async void, also .Start() and .RunSynchronoulsy() seems to deadlock

tebeco · tebeco · commit 4a2a4788c8e4 · 2017-11-03T18:31:01.000+01:00
diff --git a/README.md b/README.md
@@ -38,7 +38,7 @@ public static IWebHost BuildWebHost(string[] args)
 Open the Electron Window in the Startup.cs file: 
 
 ```csharp
-public async void Configure(IApplicationBuilder app, IHostingEnvironment env)
+public void Configure(IApplicationBuilder app, IHostingEnvironment env)
 {
     if (env.IsDevelopment())
     {
@@ -60,7 +60,7 @@ public async void Configure(IApplicationBuilder app, IHostingEnvironment env)
     });
 
     // Open the Electron-Window here
-    await Electron.WindowManager.CreateWindowAsync();
+    Task.Run(async () => await Electron.WindowManager.CreateWindowAsync());
 }
 ```
 

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public static IWebHost BuildWebHost(string[] args)`
`38`	`38`	`Open the Electron Window in the Startup.cs file:`
`39`	`39`
`40`	`40`	```csharp
`41`		`-public async void Configure(IApplicationBuilder app, IHostingEnvironment env)`
	`41`	`+public void Configure(IApplicationBuilder app, IHostingEnvironment env)`
`42`	`42`	`{`
`43`	`43`	`if (env.IsDevelopment())`
`44`	`44`	`{`
`@@ -60,7 +60,7 @@ public async void Configure(IApplicationBuilder app, IHostingEnvironment env)`
`60`	`60`	`});`
`61`	`61`
`62`	`62`	`// Open the Electron-Window here`
`63`		`- await Electron.WindowManager.CreateWindowAsync();`
	`63`	`+ Task.Run(async () => await Electron.WindowManager.CreateWindowAsync());`
`64`	`64`	`}`
`65`	`65`	```
`66`	`66`