Conversation
Contributor
📝 WalkthroughWalkthroughAdds before/after middleware strategies to ChatBuilder; fixes SSE parser to flush buffered events on type switches; cleans comments across core, providers, and examples; requests include_usage in Completions streams; loosens provider builder APIs; and introduces a full docs site (TanStack Start + Fumadocs) with routes, components, and MDX content. ChangesCore runtime, providers, and examples
Documentation application
Sequence Diagram(s)sequenceDiagram
participant Browser
participant FileRoute as /docs/$
participant ServerFn as createServerFn
participant Source as Fumadocs Source
participant ClientLoader
Browser->>FileRoute: navigate /docs/...
FileRoute->>ServerFn: loader(slugs)
ServerFn->>Source: getPage/serializeTree
Source-->>ServerFn: page, tree
ServerFn-->>FileRoute: path + tree
FileRoute->>ClientLoader: preload(path)
ClientLoader-->>Browser: render MDX
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
docs/vite.config.ts (1)
16-16: ⚡ Quick winRemove the redundant
as PluginOptioncast for the Alchemy Vite plugin.
alchemyfromalchemy/cloudflare/tanstack-startis already typed to return Vite-compatiblePluginOption(the wrapper returns aPluginOption, including an array cast), soalchemy() as PluginOptionindocs/vite.config.tsis unnecessary and can be dropped.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/vite.config.ts` at line 16, Remove the redundant type assertion on the Alchemy Vite plugin: locate the usage of alchemy() as PluginOption and replace it with just alchemy() (the alchemy export already returns a Vite-compatible PluginOption/array), so drop the "as PluginOption" cast from the plugin array or config where alchemy is included.docs/src/router.tsx (1)
9-9: ⚡ Quick winConsider increasing
defaultPreloadStaleTimefor static documentation.Setting
defaultPreloadStaleTime: 0means preloaded routes are immediately considered stale and will refetch when navigated to, making the preload effort wasted. For a documentation site with static MDX content, consider using a longer stale time (e.g.,Infinityor a large value) to benefit from preloading.⚡ Proposed optimization
export const getRouter = () => { return createRouter({ routeTree, scrollRestoration: true, - defaultPreloadStaleTime: 0, + defaultPreloadStaleTime: Infinity, // or remove this line to use TanStack Router's default }); };🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/src/router.tsx` at line 9, The router config currently sets defaultPreloadStaleTime: 0 causing preloaded MDX routes to be immediately stale; update the router preload/stale-time setting (defaultPreloadStaleTime) to a much longer duration (e.g., Infinity or a large millisecond value) in the router configuration where defaultPreloadStaleTime is defined so preloaded static docs remain fresh and avoid unnecessary refetches.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/public/manifest.json`:
- Around line 2-3: Update the PWA manifest metadata by replacing the placeholder
TanStack values in the JSON fields "short_name" and "name" with the chat-rs
project identifiers (e.g., short_name: "chat-rs" and name: "chat-rs" or a more
descriptive project title). Locate the keys "short_name" and "name" in the
manifest.json and change their string values so the install prompt and app
launcher display the correct project name.
In `@docs/README.md`:
- Around line 11-24: The fenced code block showing the project tree in README.md
is missing a language tag and triggers markdownlint MD040; update that block
(the code fence wrapping the directory tree) to include a language identifier
such as "text" (i.e., change the opening ``` to ```text) so the lint warning is
cleared and formatting matches the other fenced blocks in the file.
---
Nitpick comments:
In `@docs/src/router.tsx`:
- Line 9: The router config currently sets defaultPreloadStaleTime: 0 causing
preloaded MDX routes to be immediately stale; update the router
preload/stale-time setting (defaultPreloadStaleTime) to a much longer duration
(e.g., Infinity or a large millisecond value) in the router configuration where
defaultPreloadStaleTime is defined so preloaded static docs remain fresh and
avoid unnecessary refetches.
In `@docs/vite.config.ts`:
- Line 16: Remove the redundant type assertion on the Alchemy Vite plugin:
locate the usage of alchemy() as PluginOption and replace it with just alchemy()
(the alchemy export already returns a Vite-compatible PluginOption/array), so
drop the "as PluginOption" cast from the plugin array or config where alchemy is
included.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 19aabef7-cd6d-4546-9cdd-217b7c00385b
⛔ Files ignored due to path filters (4)
docs/bun.lockis excluded by!**/*.lockdocs/public/favicon.icois excluded by!**/*.icodocs/public/logo192.pngis excluded by!**/*.pngdocs/public/logo512.pngis excluded by!**/*.png
📒 Files selected for processing (80)
core/src/builder.rscore/src/chat/completion.rscore/src/chat/mod.rscore/src/chat/stream/handle.rscore/src/chat/stream/input.rscore/src/chat/stream/mod.rscore/src/transport/impls/tokio_tungstenite.rscore/src/transport/impls/tungstenite.rscore/src/transport/sse.rscore/src/types/messages/mod.rscore/src/types/messages/parts.rscore/src/types/metadata/mod.rscore/src/types/metadata/usage.rscore/src/types/options.rscore/src/types/tools.rsdocs/.cta.jsondocs/.env.exampledocs/.gitignoredocs/.vscode/settings.jsondocs/README.mddocs/alchemy.run.tsdocs/content/docs/getting-started.mdxdocs/content/docs/index.mdxdocs/content/docs/meta.jsondocs/content/docs/openrouter.mdxdocs/content/docs/providers.mdxdocs/package.jsondocs/public/manifest.jsondocs/public/robots.txtdocs/source.config.tsdocs/src/components/mdx.tsxdocs/src/lib/layout.shared.tsxdocs/src/lib/source.tsdocs/src/routeTree.gen.tsdocs/src/router.tsxdocs/src/routes/__root.tsxdocs/src/routes/api/search.tsdocs/src/routes/docs/$.tsxdocs/src/routes/index.tsxdocs/src/styles.cssdocs/tsconfig.jsondocs/types/env.d.tsdocs/vite.config.tsexamples/claude/hitl.rsexamples/claude/stream.rsexamples/gemini/classification.rsexamples/gemini/google_maps.rsexamples/gemini/hitl.rsexamples/gemini/image_generation.rsexamples/gemini/image_understanding.rsexamples/gemini/stream.rsexamples/gemini/youtube.rsexamples/mistralrs/voice.rsexamples/ollama/stream.rsexamples/openai/hitl.rsexamples/openai/input_stream.rsexamples/openai/interactive.rsexamples/openai/websocket.rsexamples/router/capability.rsproviders/claude/src/api/stream.rsproviders/claude/src/api/types/error.rsproviders/claude/src/api/types/request.rsproviders/completions/src/api/stream.rsproviders/completions/src/api/types/error.rsproviders/completions/src/api/types/request.rsproviders/completions/src/api/types/response.rsproviders/gemini/src/api/types/error.rsproviders/gemini/src/api/types/request.rsproviders/gemini/src/api/types/response.rsproviders/mistralrs/src/api/stream.rsproviders/mistralrs/src/lib.rsproviders/ollama/src/lib.rsproviders/responses/src/api/stream.rsproviders/responses/src/api/types/error.rsproviders/responses/src/api/types/request.rsproviders/responses/src/api/types/response.rsproviders/router/src/circuit_breaker.rsproviders/router/src/lib.rsproviders/router/src/router.rsproviders/router/src/stream_router.rs
💤 Files with no reviewable changes (40)
- examples/gemini/image_understanding.rs
- examples/ollama/stream.rs
- examples/openai/input_stream.rs
- providers/claude/src/api/types/error.rs
- providers/ollama/src/lib.rs
- examples/openai/websocket.rs
- core/src/types/messages/mod.rs
- examples/gemini/image_generation.rs
- core/src/types/tools.rs
- examples/gemini/youtube.rs
- core/src/types/metadata/mod.rs
- examples/router/capability.rs
- providers/mistralrs/src/api/stream.rs
- core/src/transport/sse.rs
- providers/completions/src/api/types/error.rs
- providers/completions/src/api/types/response.rs
- providers/mistralrs/src/lib.rs
- core/src/chat/stream/handle.rs
- examples/gemini/google_maps.rs
- core/src/chat/stream/input.rs
- providers/claude/src/api/types/request.rs
- providers/responses/src/api/types/error.rs
- providers/completions/src/api/stream.rs
- providers/gemini/src/api/types/response.rs
- providers/responses/src/api/types/response.rs
- providers/gemini/src/api/types/error.rs
- providers/router/src/stream_router.rs
- core/src/types/metadata/usage.rs
- core/src/chat/stream/mod.rs
- providers/responses/src/api/stream.rs
- core/src/chat/completion.rs
- core/src/types/messages/parts.rs
- providers/completions/src/api/types/request.rs
- core/src/builder.rs
- examples/gemini/hitl.rs
- providers/router/src/router.rs
- providers/responses/src/api/types/request.rs
- examples/gemini/classification.rs
- core/src/transport/impls/tokio_tungstenite.rs
- providers/router/src/lib.rs
Comment on lines
+11
to
+24
| ``` | ||
| docs/ | ||
| ├── content/docs/ ← MDX documentation pages | ||
| ├── src/ | ||
| │ ├── routes/ | ||
| │ │ ├── index.tsx ← landing page | ||
| │ │ ├── docs/$.tsx ← Fumadocs catch-all docs route | ||
| │ │ └── api/search.ts ← search endpoint | ||
| │ ├── lib/source.ts ← Fumadocs content source | ||
| │ └── components/mdx.tsx | ||
| ├── source.config.ts ← fumadocs-mdx collection config | ||
| ├── alchemy.run.ts ← Cloudflare deploy definition | ||
| └── vite.config.ts | ||
| ``` |
Contributor
There was a problem hiding this comment.
Add a language to the fenced code block.
markdownlint (MD040) flags this block. Tagging it (e.g. text) clears the lint warning and is consistent with the other fenced blocks in this file.
📝 Proposed fix
-```
+```text
docs/
├── content/docs/ ← MDX documentation pages🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 11-11: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/README.md` around lines 11 - 24, The fenced code block showing the
project tree in README.md is missing a language tag and triggers markdownlint
MD040; update that block (the code fence wrapping the directory tree) to include
a language identifier such as "text" (i.e., change the opening ``` to ```text)
so the lint warning is cleared and formatting matches the other fenced blocks in
the file.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
docs/src/components/FaultyTerminal.tsx (1)
399-419: 💤 Low value
gridMularray literal in deps re-initializes the WebGL context on every re-render.
gridMulis an object dependency, and the homepage passes a new[2, 1]literal each render. Whenever the parent re-renders, the effect tears down and recreates the renderer/program/observer instead of just updating the uniform. Today the parent rarely re-renders so impact is small, but it's a sharp edge. Consider memoizing the value (liketintVec/ditherValue) and depending on the stable reference.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/src/components/FaultyTerminal.tsx` around lines 399 - 419, The effect in FaultyTerminal re-creates the WebGL renderer because gridMul is an unstable array literal in the deps; fix by using a stable reference instead of the raw array: either memoize gridMul in the parent (so the homepage passes a stable array) or derive a stable local value inside FaultyTerminal (e.g. const stableGridMul = useMemo(() => [gridMul[0], gridMul[1]], [gridMul[0], gridMul[1]])) and replace gridMul in the useEffect dependency list with that stableGridMul (or its scalar components) so the renderer/program/observer are not torn down on every re-render.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/content/docs/providers/router.mdx`:
- Around line 261-268: The docs imply Router directly supports embeddings;
instead, clarify that embedding-based ranking requires the strategy to call a
separate embeddings-capable client — Router itself does not implement embeddings
or handle chat.embed() calls. Update the "Advanced: routing by embeddings"
paragraph to add a sentence stating that the strategy must obtain embeddings
from a single embedding provider/client (e.g., via an embeddings client used
inside the strategy's rank function) and that Router does not serve chat.embed()
itself. Mention the Router type and the strategy's rank method to make it clear
where to perform embedding calls.
In `@docs/src/components/FaultyTerminal.tsx`:
- Line 422: The div rendering in FaultyTerminal.tsx uses a template string that
appends className directly, which yields a literal "undefined" class when
className is not provided; update the JSX for the div (the element with
ref={containerRef} and props style and {...rest}) to join classes conditionally
instead of interpolating undefined—either wrap className in a ternary (e.g.,
baseClasses + (className ? ` ${className}` : '')) or use the existing cn helper
(cn('w-full h-full relative overflow-hidden', className)); ensure to import/use
cn if not already imported and keep ref={containerRef}, style, and {...rest}
unchanged.
- Line 260: The default for the dpr prop in FaultyTerminal currently reads from
window (dpr = Math.min(window.devicePixelRatio || 1, 2)) which will throw during
SSR; change the default to guard window access (e.g., use typeof window !==
"undefined" ? Math.min(window.devicePixelRatio || 1, 2) : 1) so server renders
use a safe fallback. Locate the dpr default in the FaultyTerminal component and
replace the direct window access with the guarded expression so omitted dpr
props are SSR-safe.
In `@docs/src/styles.css`:
- Line 147: Remove unnecessary quotes around single-token font family names to
satisfy stylelint's font-family-name-quotes rule: update the font-family
declarations that use "Orbit" and "Geist" so they are unquoted (e.g., change
"Orbit" -> Orbit and "Geist" -> Geist) while keeping fallback families
(ui-monospace, monospace) intact; locate these in the CSS rule containing
font-family: "Orbit", ui-monospace, monospace and the `@theme` block that declares
"Geist" and drop the quotes.
---
Nitpick comments:
In `@docs/src/components/FaultyTerminal.tsx`:
- Around line 399-419: The effect in FaultyTerminal re-creates the WebGL
renderer because gridMul is an unstable array literal in the deps; fix by using
a stable reference instead of the raw array: either memoize gridMul in the
parent (so the homepage passes a stable array) or derive a stable local value
inside FaultyTerminal (e.g. const stableGridMul = useMemo(() => [gridMul[0],
gridMul[1]], [gridMul[0], gridMul[1]])) and replace gridMul in the useEffect
dependency list with that stableGridMul (or its scalar components) so the
renderer/program/observer are not torn down on every re-render.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6ebf3743-9749-4893-b98e-fd388d391ec0
⛔ Files ignored due to path filters (1)
docs/bun.lockis excluded by!**/*.lock
📒 Files selected for processing (60)
core/src/builder.rsdocs/components.jsondocs/content/docs/capabilities/embeddings.mdxdocs/content/docs/capabilities/index.mdxdocs/content/docs/capabilities/meta.jsondocs/content/docs/capabilities/multimodal.mdxdocs/content/docs/capabilities/streaming.mdxdocs/content/docs/capabilities/structured-output.mdxdocs/content/docs/getting-started.mdxdocs/content/docs/index.mdxdocs/content/docs/meta.jsondocs/content/docs/middleware/index.mdxdocs/content/docs/middleware/meta.jsondocs/content/docs/middleware/retries.mdxdocs/content/docs/providers/cerebras.mdxdocs/content/docs/providers/claude.mdxdocs/content/docs/providers/completions.mdxdocs/content/docs/providers/deepseek.mdxdocs/content/docs/providers/gemini.mdxdocs/content/docs/providers/huggingface.mdxdocs/content/docs/providers/index.mdxdocs/content/docs/providers/meta.jsondocs/content/docs/providers/mistralrs.mdxdocs/content/docs/providers/ollama.mdxdocs/content/docs/providers/openai.mdxdocs/content/docs/providers/openrouter.mdxdocs/content/docs/providers/responses.mdxdocs/content/docs/providers/router.mdxdocs/content/docs/tools/context.mdxdocs/content/docs/tools/human-in-the-loop.mdxdocs/content/docs/tools/index.mdxdocs/content/docs/tools/meta.jsondocs/content/docs/tools/native.mdxdocs/content/docs/tools/python.mdxdocs/content/docs/traits/completion-provider.mdxdocs/content/docs/traits/embeddings-provider.mdxdocs/content/docs/traits/index.mdxdocs/content/docs/traits/meta.jsondocs/content/docs/traits/stream-provider.mdxdocs/package.jsondocs/public/icon-dark.webpdocs/public/icon-light.webpdocs/public/logo-dark.webpdocs/public/logo-light.webpdocs/public/manifest.jsondocs/src/components/FaultyTerminal.tsxdocs/src/components/code-gallery.tsxdocs/src/components/copyable-code.tsxdocs/src/components/ui/badge.tsxdocs/src/components/ui/button.tsxdocs/src/components/ui/card.tsxdocs/src/components/ui/separator.tsxdocs/src/components/ui/tabs.tsxdocs/src/lib/layout.shared.tsxdocs/src/lib/utils.tsdocs/src/routes/__root.tsxdocs/src/routes/index.tsxdocs/src/styles.cssproviders/claude/src/lib.rsproviders/gemini/src/lib.rs
✅ Files skipped from review due to trivial changes (29)
- docs/content/docs/middleware/meta.json
- docs/content/docs/providers/meta.json
- docs/src/lib/utils.ts
- docs/src/components/ui/separator.tsx
- docs/content/docs/traits/meta.json
- docs/content/docs/capabilities/index.mdx
- docs/content/docs/capabilities/meta.json
- docs/content/docs/capabilities/embeddings.mdx
- docs/content/docs/traits/stream-provider.mdx
- docs/content/docs/providers/ollama.mdx
- docs/content/docs/middleware/retries.mdx
- docs/src/components/ui/card.tsx
- docs/content/docs/traits/index.mdx
- docs/content/docs/tools/meta.json
- docs/content/docs/providers/cerebras.mdx
- docs/content/docs/getting-started.mdx
- docs/content/docs/tools/python.mdx
- docs/content/docs/providers/openrouter.mdx
- docs/content/docs/tools/index.mdx
- docs/content/docs/tools/human-in-the-loop.mdx
- docs/content/docs/traits/completion-provider.mdx
- docs/content/docs/providers/huggingface.mdx
- docs/content/docs/tools/native.mdx
- docs/content/docs/providers/mistralrs.mdx
- docs/content/docs/middleware/index.mdx
- docs/content/docs/index.mdx
- docs/content/docs/providers/index.mdx
- docs/content/docs/providers/openai.mdx
- docs/content/docs/traits/embeddings-provider.mdx
🚧 Files skipped from review as they are similar to previous changes (4)
- docs/public/manifest.json
- docs/src/lib/layout.shared.tsx
- docs/package.json
- docs/src/routes/__root.tsx
Comment on lines
+261
to
+268
| ## Advanced: routing by embeddings | ||
|
|
||
| Because a strategy can do async work inside `rank`, you are not limited to | ||
| keyword matching. `examples/router/embeddings.rs` embeds a short description of | ||
| each provider at build time, stores the vector under | ||
| `.with_metadata("embedding", vector)`, and at request time embeds the user's | ||
| message and ranks providers by cosine similarity. That gives you semantic | ||
| routing without changing anything about how the Router is built or used. |
Contributor
There was a problem hiding this comment.
Clarify that embedding-based ranking still uses a separate embeddings client.
This section reads close to “Router supports embeddings,” but routing by embeddings only works if the strategy calls some separate embeddings-capable provider/client. Add one sentence making it explicit that Router still cannot serve chat.embed() itself.
Based on learnings: "Router does not support embeddings—embeddings must use a single provider without routing".
🧰 Tools
🪛 LanguageTool
[style] ~264-~264: Consider using the synonym “brief” (= concise, using a few words, not lasting long) to strengthen your wording.
Context: ...examples/router/embeddings.rs` embeds a short description of each provider at build t...
(QUICK_BRIEF)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/content/docs/providers/router.mdx` around lines 261 - 268, The docs
imply Router directly supports embeddings; instead, clarify that embedding-based
ranking requires the strategy to call a separate embeddings-capable client —
Router itself does not implement embeddings or handle chat.embed() calls. Update
the "Advanced: routing by embeddings" paragraph to add a sentence stating that
the strategy must obtain embeddings from a single embedding provider/client
(e.g., via an embeddings client used inside the strategy's rank function) and
that Router does not serve chat.embed() itself. Mention the Router type and the
strategy's rank method to make it clear where to perform embedding calls.
| tint = '#ffffff', | ||
| mouseReact = true, | ||
| mouseStrength = 0.2, | ||
| dpr = Math.min(window.devicePixelRatio || 1, 2), |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Does TanStack Start server-side render route components by default?
💡 Result:
Yes, TanStack Start renders route components on the server by default [1][2]. When this default behavior is active, the following occurs during the initial server request: - The route's beforeLoad and loader functions are executed on the server [1][3]. - The route component is rendered on the server to generate HTML, which is then sent to the client for hydration [1][3]. This behavior can be configured or disabled globally or on a per-route basis [1][3]: - Per-Route: You can set the ssr property to false in a route's configuration to disable server-side execution of loaders and server-side rendering of the component for that specific route [1][3]. - Globally: You can change the default SSR behavior for the entire application using the defaultSsr option within the createStart configuration [1][3][4]. Note that child routes inherit the ssr configuration from their parent, and they can only be restricted further (e.g., a child route cannot enable SSR if the parent has explicitly disabled it) [1][3].
Citations:
- 1: https://tanstack.com/start/latest/docs/framework/react/guide/selective-ssr
- 2: https://tanstack.com/start/latest/docs/framework/react/guide/seo
- 3: https://github.com/TanStack/router/blob/main/packages/start-client-core/skills/start-core/deployment/SKILL.md
- 4: https://tanstack-router-54.mintlify.app/start/concepts/server-rendering
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Locate the file and inspect around the line with the window default param
ls -la docs/src/components/FaultyTerminal.tsx 2>/dev/null || true
sed -n '220,320p' docs/src/components/FaultyTerminal.tsx
# Find where FaultyTerminal is used and whether dpr is always passed
rg -n "FaultyTerminal" -S docs/src || true
rg -n "dpr=\{?[^}]*\}?" -S docs/src/components/FaultyTerminal.tsx docs/src || true
# Inspect router/start app configuration for SSR defaults (createStart / defaultSsr / ssr: false)
rg -n "defaultSsr|ssr\\s*:\\s*false|createStart\\(" -S docs/src . || true
# If there is a start config file, print it
fd -a "start*.ts" docs/src -tf || true
fd -a "tanstack-start*.ts" . -tf || true
fd -a "router*.ts" docs/src -tf || trueRepository: EggerMarc/chat-rs
Length of output: 3660
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show the actual file tree bits where configs might live
find docs -maxdepth 4 -type f \( -name "*start*" -o -name "*router*" -o -name "*ssr*" \) | head -n 200Repository: EggerMarc/chat-rs
Length of output: 201
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Locate the file and inspect around the line with the window default param
ls -la docs/src/components/FaultyTerminal.tsx 2>/dev/null || true
sed -n '220,320p' docs/src/components/FaultyTerminal.tsx
# Find where FaultyTerminal is used and whether dpr is always passed
rg -n "FaultyTerminal" -S docs/src || true
rg -n "dpr" -S docs/src/components/FaultyTerminal.tsx docs/src || true
# Inspect router/start app configuration for SSR defaults (createStart / defaultSsr / ssr: false)
rg -n "defaultSsr|ssr\\s*:\\s*false|createStart\\(" -S docs/src . || true
# List likely config files
find . -maxdepth 4 -type f \( -name "*start*" -o -name "*router*" -o -name "*ssr*" \) | head -n 200Repository: EggerMarc/chat-rs
Length of output: 5168
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect FaultyTerminal around the offending line
ls -la docs/src/components/FaultyTerminal.tsx 2>/dev/null || true
sed -n '240,290p' docs/src/components/FaultyTerminal.tsx
# Find where FaultyTerminal is used and how dpr is passed
rg -n "FaultyTerminal" -S docs/src || true
rg -n "FaultyTerminal\\b" -S . || true
rg -n "\\bdpr\\b" -S docs/src/components/FaultyTerminal.tsx docs/src || true
rg -n "dpr=\\{?" -S docs/src || true
# Check for TanStack Start SSR configuration
rg -n "defaultSsr|ssr\\s*:\\s*false|createStart\\(" -S . || true
# List likely start/router config files
find . -maxdepth 5 -type f \( -name "*start*" -o -name "*router*" -o -name "*ssr*" \) | head -n 200Repository: EggerMarc/chat-rs
Length of output: 3251
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect FaultyTerminal around the offending line
ls -la docs/src/components/FaultyTerminal.tsx 2>/dev/null || true
sed -n '240,290p' docs/src/components/FaultyTerminal.tsx
# Find where FaultyTerminal is used and how dpr is passed
rg -n "FaultyTerminal" -S docs/src || true
rg -n "FaultyTerminal\\b" -S . || true
rg -n "\\bdpr\\b" -S docs/src/components/FaultyTerminal.tsx docs/src || true
rg -n "dpr=\\{?" -S docs/src || true
# Check for TanStack Start SSR configuration
rg -n "defaultSsr|ssr\\s*:\\s*false|createStart\\(" -S . || true
# List likely start/router config files
find . -maxdepth 5 -type f \( -name "*start*" -o -name "*router*" -o -name "*ssr*" \) | head -n 200Repository: EggerMarc/chat-rs
Length of output: 3251
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect FaultyTerminal around the offending line
ls -la docs/src/components/FaultyTerminal.tsx 2>/dev/null || true
sed -n '240,290p' docs/src/components/FaultyTerminal.tsx
# Find where FaultyTerminal is used and how dpr is passed
rg -n "FaultyTerminal" -S docs/src || true
rg -n "FaultyTerminal\\b" -S . || true
rg -n "\\bdpr\\b" -S docs/src/components/FaultyTerminal.tsx docs/src || true
rg -n "dpr=\\{?" -S docs/src || true
# Check for TanStack Start SSR configuration
rg -n "defaultSsr|ssr\\s*:\\s*false|createStart\\(" -S . || true
# List likely start/router config files
find . -maxdepth 5 -type f \( -name "*start*" -o -name "*router*" -o -name "*ssr*" \) | head -n 200Repository: EggerMarc/chat-rs
Length of output: 3251
Guard window access in FaultyTerminal’s dpr default for SSR
dpr = Math.min(window.devicePixelRatio || 1, 2) is evaluated whenever the dpr prop is omitted; with TanStack Start server-rendering routes by default, rendering FaultyTerminal without dpr would throw on the server. Current usage passes dpr={1} (so it’s latent), but the component is still unsafe for any other render without dpr.
🛡️ Proposed guard
- dpr = Math.min(window.devicePixelRatio || 1, 2),
+ dpr = Math.min(typeof window !== "undefined" ? window.devicePixelRatio || 1 : 1, 2),📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| dpr = Math.min(window.devicePixelRatio || 1, 2), | |
| dpr = Math.min(typeof window !== "undefined" ? window.devicePixelRatio || 1 : 1, 2), |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/src/components/FaultyTerminal.tsx` at line 260, The default for the dpr
prop in FaultyTerminal currently reads from window (dpr =
Math.min(window.devicePixelRatio || 1, 2)) which will throw during SSR; change
the default to guard window access (e.g., use typeof window !== "undefined" ?
Math.min(window.devicePixelRatio || 1, 2) : 1) so server renders use a safe
fallback. Locate the dpr default in the FaultyTerminal component and replace the
direct window access with the guarded expression so omitted dpr props are
SSR-safe.
| ]); | ||
|
|
||
| return ( | ||
| <div ref={containerRef} className={`w-full h-full relative overflow-hidden ${className}`} style={style} {...rest} /> |
Contributor
There was a problem hiding this comment.
className interpolation emits a literal undefined class.
When className is unset, the template string produces "... overflow-hidden undefined", adding a stray undefined class. Use conditional joining (or the existing cn helper) instead.
🔧 Proposed fix
- <div ref={containerRef} className={`w-full h-full relative overflow-hidden ${className}`} style={style} {...rest} />
+ <div ref={containerRef} className={`w-full h-full relative overflow-hidden${className ? ` ${className}` : ""}`} style={style} {...rest} />📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <div ref={containerRef} className={`w-full h-full relative overflow-hidden ${className}`} style={style} {...rest} /> | |
| <div ref={containerRef} className={`w-full h-full relative overflow-hidden${className ? ` ${className}` : ""}`} style={style} {...rest} /> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/src/components/FaultyTerminal.tsx` at line 422, The div rendering in
FaultyTerminal.tsx uses a template string that appends className directly, which
yields a literal "undefined" class when className is not provided; update the
JSX for the div (the element with ref={containerRef} and props style and
{...rest}) to join classes conditionally instead of interpolating
undefined—either wrap className in a ternary (e.g., baseClasses + (className ? `
${className}` : '')) or use the existing cn helper (cn('w-full h-full relative
overflow-hidden', className)); ensure to import/use cn if not already imported
and keep ref={containerRef}, style, and {...rest} unchanged.
|
|
||
| /* Orbit — the "engineering drawing" voice for indices, eyebrows, tags. */ | ||
| .font-label { | ||
| font-family: "Orbit", ui-monospace, monospace; |
Contributor
There was a problem hiding this comment.
Stylelint: remove quotes around single-token font name.
font-family-name-quotes flags "Orbit" since it needs no quotes. The same applies to "Geist" on Line 55 once the @theme block parses. Drop the quotes to clear the lint error.
🔧 Proposed fix
- font-family: "Orbit", ui-monospace, monospace;
+ font-family: Orbit, ui-monospace, monospace;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| font-family: "Orbit", ui-monospace, monospace; | |
| font-family: Orbit, ui-monospace, monospace; |
🧰 Tools
🪛 Stylelint (17.12.0)
[error] 147-147: Expected no quotes around "Orbit" (font-family-name-quotes)
(font-family-name-quotes)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/src/styles.css` at line 147, Remove unnecessary quotes around
single-token font family names to satisfy stylelint's font-family-name-quotes
rule: update the font-family declarations that use "Orbit" and "Geist" so they
are unquoted (e.g., change "Orbit" -> Orbit and "Geist" -> Geist) while keeping
fallback families (ui-monospace, monospace) intact; locate these in the CSS rule
containing font-family: "Orbit", ui-monospace, monospace and the `@theme` block
that declares "Geist" and drop the quotes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
with_before_strategyandwith_after_strategyfor callback hooks.Documentation
Refactor