Skip to content

🎨 Palette: Add aria-label to search inputs #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EffortlessSteven wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

🎨 Palette: Add aria-label to search inputs #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
61e206c
🎨 Palette: Add aria-label to search inputs
EffortlessSteven Mar 31, 2026
685deb4
🎨 Palette: Add aria-label to search inputs
EffortlessSteven Mar 31, 2026
092723c
🎨 Palette: Add aria-label to search inputs
EffortlessSteven Mar 31, 2026
8cdcf0e
🎨 Palette: Add aria-label to search inputs
EffortlessSteven Mar 31, 2026
fa74ee4
🎨 Palette: Add aria-label to search inputs
EffortlessSteven Mar 31, 2026
7032a05
🎨 Palette: Add aria-label to search inputs
EffortlessSteven Mar 31, 2026
9fc00a3
🎨 Palette: Add aria-label to search inputs
EffortlessSteven Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .cargo/audit.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ ignore = [
# RUSTSEC-2023-0071: rsa Marvin Attack - transitive from sqlx-mysql, no fix available
# Timing side-channel; acceptable for this template. See ADR-0007.
"RUSTSEC-2023-0071",
# RUSTSEC-2026-0066: astral-tokio-tar is locked by testcontainers, see ADR-0007
"RUSTSEC-2026-0066",
# RUSTSEC-2025-0057: fxhash unmaintained - dev-only via selectors/scraper
# Waiting for upstream selectors fix
"RUSTSEC-2025-0057",
Expand Down
14 changes: 7 additions & 7 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/app-http/src/platform/ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,7 @@ pub async fn coverage_view(State(state): State<AppState>) -> Html<String> {
button #filter-failing.filter-btn onclick="filterData('failing')" { "Failing" }
button #filter-unknown.filter-btn onclick="filterData('unknown')" { "Unknown" }
input #search-box.search-box type="text" placeholder="Search by AC ID or title..."
aria-label="Search by AC ID or title"
Comment on lines 807 to +808
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding aria-label is a significant accessibility improvement, using type="search" instead of type="text" is a better practice for search inputs. It semantically identifies the field's purpose to assistive technologies and provides built-in browser features like a 'clear' button. Additionally, the aria-label should ideally match the placeholder text exactly (including the ellipsis if it's considered part of the label) or be even more concise.

Suggested change
input #search-box.search-box type="text" placeholder="Search by AC ID or title..."
aria-label="Search by AC ID or title"
input #search-box.search-box type="search" placeholder="Search by AC ID or title..."
aria-label="Search by AC ID or title..."

oninput="searchData()";
}

Expand Down
1 change: 1 addition & 0 deletions crates/http-platform/src/ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,7 @@ fn coverage_content() -> Markup {
button #filter-failing.filter-btn onclick="filterData('failing')" { "Failing" }
button #filter-unknown.filter-btn onclick="filterData('unknown')" { "Unknown" }
input #search-box.search-box type="text" placeholder="Search by AC ID or title..."
aria-label="Search by AC ID or title"
Comment on lines 628 to +629
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better accessibility and semantic correctness, consider changing the input type to search. This helps screen readers identify the field as a search box and enables browser-specific UI enhancements. Also, ensure the aria-label is consistent with the placeholder text.

Suggested change
input #search-box.search-box type="text" placeholder="Search by AC ID or title..."
aria-label="Search by AC ID or title"
input #search-box.search-box type="search" placeholder="Search by AC ID or title..."
aria-label="Search by AC ID or title..."

oninput="searchData()";
}

Expand Down
1 change: 1 addition & 0 deletions deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
# - We use the latest testcontainers version
#
ignore = [
"RUSTSEC-2026-0066", # astral-tokio-tar is locked by testcontainers, see ADR-0007
# RUSTSEC-2023-0071 (rsa Marvin Attack)
# - Path: rsa → jsonwebtoken → app-http
# - Risk: Timing sidechannel, mitigated by JWT-only usage (no raw RSA decryption)
Expand Down
Loading