🛡️ Sentinel: [HIGH] Fix timing side-channel in constant_time_eq#328
🛡️ Sentinel: [HIGH] Fix timing side-channel in constant_time_eq#328EffortlessSteven wants to merge 2 commits intomainfrom
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 21 minutes and 10 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (34)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Results283 tests 245 ✅ 11m 14s ⏱️ Results for commit 8fcd2cd. ♻️ This comment has been updated with latest results. |
|
Hint: prefix PR titles with |
1 participant
Scope
Type: Security Fix
Intent: Address a potential timing side-channel in the token verifier's constant-time equality check.
Touchpoints:
crates/http-auth-verifier/src/lib.rscrates/http-auth-verifier/Cargo.toml(implicit viacargo add)Evidence:
cargo test -p http-auth-verifierpasses, verifying that all expected behavior remains identical.ct_eqensures constant-time operations through compiler black-boxes.Context
🚨 Severity: HIGH
💡 Vulnerability: The
constant_time_eqmethod implemented a manual constant-time check (left.bytes().zip(right.bytes()).fold(0_u8, |acc, (x, y)| acc | (x ^ y)) == 0). While this attempts to process all bytes without early exit, LLVM optimizations (like auto-vectorization, loop unrolling, or converting it back to a variable-timememcmp) can re-introduce timing leaks.🎯 Impact: Attackers could theoretically infer token bytes through timing side-channels by repeatedly making requests and measuring response latency down to the microsecond level.
🔧 Fix: Updated the logic to use the
subtlecrate'sConstantTimeEqimplementation (ct_eq). This crate leverages inline assembly and optimization barriers (core::hint::black_box) to provide strict constant-time guarantees. Addedsubtle@2.6.1tohttp-auth-verifierdependencies.✅ Verification: Ran
cargo test -p http-auth-verifierto ensure all functionality and property tests for equality continue to pass.PR created automatically by Jules for task 14731761870236442074 started by @EffortlessSteven