Skip to content

Remove instanceof check from HttpApiSchema module #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-smart merged 2 commits into from
Jan 12, 2026
Merged

Remove instanceof check from HttpApiSchema module #848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc475d7
remove instanceof from httpapischema module
IMax153 Dec 17, 2025
0eedede
fix check
IMax153 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/effect/src/unstable/httpapi/HttpApiSchema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import type { YieldableError } from "../../Cause.ts"
import type * as FileSystem from "../../FileSystem.ts"
import { constant, constVoid, dual, type LazyArg } from "../../Function.ts"
import * as Iterable from "../../Iterable.ts"
import * as Predicate from "../../Predicate.ts"
import * as Schema from "../../Schema.ts"
import * as AST from "../../SchemaAST.ts"
import * as Transformation from "../../SchemaTransformation.ts"
Expand Down Expand Up @@ -513,6 +514,8 @@ export interface EmptyErrorClass<Self, Tag> extends
new(): { readonly _tag: Tag } & YieldableError
}

const EmptyErrorTypeId = "~effect/httpapi/HttpApiSchema/EmptyError"

/**
* @since 4.0.0
* @category empty errors
Expand All @@ -527,8 +530,10 @@ export const EmptyError = <Self>() =>
}, {
id: options.tag
}) {
readonly [EmptyErrorTypeId]: typeof EmptyErrorTypeId
constructor() {
super({}, { disableValidation: true })
this[EmptyErrorTypeId] = EmptyErrorTypeId
this.name = options.tag
}
}
Expand All @@ -542,7 +547,7 @@ export const EmptyError = <Self>() =>
const decoded = new self()
decoded.stack = options.tag
transform = asEmpty(
Schema.declare((u) => u instanceof EmptyError, {
Schema.declare((u: unknown) => Predicate.hasProperty(u, EmptyErrorTypeId), {
identifier: options.tag
}),
{
Expand Down