chore(color): helper script to convert SVG firmware graphics to PNG#6772
chore(color): helper script to convert SVG firmware graphics to PNG#6772
Conversation
|
resvg is more about performance (i.e. it's faster) and standards compliance, as well as better at handing more complex SVGs than what rsvg-convert (librsvg) is. But you don't get anything for free... given we're still talking about PNGs (rather than a complete change of format) ... improved quality is usually going to be at the expense of file size/usage... so if rsvg-convert is still making good enough quality images (to be honest, I don't think you'd tell the difference given the screens currently in use) and doesn't choke on the SVG source files ... I'd vote for smaller sizes over quality. I simply avoided it due to cairo (which rsvg-convert uses for rendering) having a history of issues with "complex" SVGs. |
|
Differences are minimal, with resolution like 800x480 and less jagged edges is not an issue because all edges are jagged anyway :) I can't spot any quirks even in complex SVG like logo above. |
|
Just for consideration, higher DPI displays are likely |
1. added CSV with basic dimensions (480x272) 2. modified script - added CSV reading -- changed PNG converting to --make [320x240|480x272|800x480|all] [additional resolutions...]" - added --validate [svg | png | all] - added --update-list
Wnen --help is passed or no params > info displayed
i.e. make CSV handling both Linux/MacOS/Windows agnostic
|
@pfeerick In this PR:
Somehow while generating all gfx Github claimed all are new files. So added --update flag and "modified" field to CSV
Now |




Summary of changes:
Supersedes #6762, may replace #6768.
TODO:
--validatelike option that checks for PNGs without SVGs, SVGs without PNGs--clean-slatelike option that deletes all PNGs in the image folders and regenerates from SVG