Show Nym mixnet warning in stake/unstake/claim scenes#5995
Open
Show Nym mixnet warning in stake/unstake/claim scenes#5995
Conversation
e0a8784 to
2f6398a
Compare
2f6398a to
2018c48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana task
Asana: Earn - Nym Mixnet warning
Adds the existing Nym mixnet warning (already used in the Send scene) to the Stake, Unstake, and Claim Rewards scenes so users are informed that staking transactions may take longer to broadcast when Nym mixnet is active.
isNymActivederived fromwallet.currencyConfig.userSettings(same pattern asSendScene2).lstrings.settings_nym_mixnet_warning_title/settings_nym_mixnet_warning_bodyviaAlertCardUi4wrapped inEdgeAnim.StakeModifyScenehandlesstake,unstake, andclaimmodes viaroute.params.modification, so a single insertion covers all three scenes.StakeModifySceneComponenttoReact.FC<Props>to clear a pre-existing lint warning in the same file (separate commit).Note
Low Risk
UI-only gating/conditional rendering based on existing wallet settings; no transaction creation/signing logic changes.
Overview
Adds a Nym Mixnet warning banner to
StakeModifyScene(covering stake/unstake/claim flows) whenwallet.currencyConfig.userSettings.networkPrivacyis set tonym, using the existing localized strings and an animatedAlertCardUi4.Also updates
StakeModifySceneComponenttyping toReact.FC, tweaks warning/footer spacing, and records the change inCHANGELOG.md.Reviewed by Cursor Bugbot for commit 2018c48. Bugbot is set up for automated code reviews on this repo. Configure here.