feat(core): add timeout fallback for change-server subscription responses#695
Merged
feat(core): add timeout fallback for change-server subscription responses#695
Conversation
swansontec
requested changes
Jan 16, 2026
055aed9 to
e200b90
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
3922df2 to
170c3a0
Compare
swansontec
approved these changes
Jan 21, 2026
…nses If the change-server subscription response does not occur within 15 seconds, the wallet's mode switches to polling while waiting for the subscription response. When the response is received, the wallet returns to subscribed mode. This limits the worst-case sync delay when change-server is available but unresponsive to only 15 seconds before falling back to polling.
The result processing loop was using stale wallet data captured in indexToWalletId before the await.
Avoids destructuring mutable state which can lead to stale references.
170c3a0 to
67a12f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the change-server subscription response does not occur within 15 seconds, the wallet's mode switches to polling while waiting for the subscription response. When the response is received, the wallet returns to subscribed mode.
This limits the worst-case sync delay when change-server is available but unresponsive to only 15 seconds before falling back to polling.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Improves resilience of change-server subscriptions by falling back to polling when responses are slow.
CHANGE_SERVER_SUBSCRIPTION_TIMEOUT_MS) incurrency-pixieto mark pending subscriptions assubscribingSlowly, enabling polling; cleared when subscribe results return; timeout cleaned up indestroy()ChangeServiceSubscriptionStatuswithsubscribingSlowlyand include it in subscription status transitions and filterscurrency-wallet-pixieto runsyncNetworkpolling when status includessubscribingSlowlychangeServiceManagerto an object withupdate/destroy, and ensure subscription batching, status updates, and lifecycle handling respect the new fallback pathCHANGELOG.mdwith the new behaviorWritten by Cursor Bugbot for commit 67a12f9. This will update automatically on new commits. Configure here.