Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a warning for users when they select "CDStub" as a search type while also changing the default table model parameter.
- Changed the default table model parameter from "CDStub" to "Release".
- Reordered the search type options and added an action listener to warn users about CDStub usage.
Files not reviewed (1)
- src/main/resources/version.properties: Language not supported
Comments suppressed due to low confidence (1)
src/main/java/com/CDPrintable/ProgramWindow.java:160
- [nitpick] The warning message is clear; however, consider if warning the user without preventing the search might still lead to confusion. It may be beneficial to integrate additional UI feedback or update the table model dynamically based on the selection.
searchTypeComboBox.addActionListener(_ -> { ... if (searchTypeComboBox.getSelectedItem() != null && searchTypeComboBox.getSelectedItem().equals("CDStub")) { JOptionPane.showMessageDialog(null, "CDStubs do not have track numbers. Because of this, they will all be shown as track 0.", "Warning", JOptionPane.WARNING_MESSAGE); } ... } );
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now we warn people when we use cdstubs