Skip to content

test: extra webhook params #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Justintime50 merged 23 commits into from
Feb 21, 2025
Merged

test: extra webhook params #343

Justintime50 merged 23 commits into from
Feb 21, 2025

Conversation

@Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Feb 14, 2025 •
edited
Loading

Description

  • Adds WebhookCustomHeader model, allowing custom_headers to be passed when creating/updating a webhook
  • Corrects payload wrapping for updating a webhook
  • Bumps dependencies

Testing

  • Tests new webhook params

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50
test: extra webhook params
58b2f46
@Justintime50
chore: debug logging on build for CI
2793395
@Justintime50
chore: add missing compiler arg
299b5da
@Justintime50
chore: switch java distribution from zulu to temurin
6955ad9
@Justintime50
chore: remove unsupported java versions from CI
659867a
@Justintime50
chore: put back deps
1146a14
@Justintime50
fix: build
c77aa45
@Justintime50
chore: use builtin cache mechanism
1d24eaf
@Justintime50
chore: enable debugging
e125b30
@Justintime50
chore: bump all plugins
3da7852
@Justintime50
chore: add full stack traces
1721ca1
@Justintime50
chore: attempt to simplify build, bump template plugin
91d95a7
@Justintime50
chore: further simplify plugins
b10ba14
@Justintime50
chore: bump dependencies
29e1d63
@Justintime50
fix: errorprone arg
6513d00
@Justintime50
chore: attempt java 21 vs 23
64b1ffd
@Justintime50
chore: put back the things
99602e4
@Justintime50
fix: mockito reference
e44c8da
@Justintime50
fix: downgrade dep checker
2abd2be
@Justintime50
test: custom headers params
10402f8
@Justintime50
docs: adds missing changelog info
1491251
@Justintime50 Justintime50 marked this pull request as ready for review February 20, 2025 17:00
@Justintime50 Justintime50 requested a review from a team as a code owner February 20, 2025 17:00
keheitz
keheitz approved these changes Feb 21, 2025
View reviewed changes
Copy link

@keheitz keheitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Justintime50 Justintime50 merged commit 663a19a into master Feb 21, 2025
21 checks passed
@Justintime50 Justintime50 deleted the webhook_params branch February 21, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keheitz keheitz keheitz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Justintime50 @keheitz