Make casts from existing single sided formulas to two sided ones use a more robust pattern #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskgo
force-pushed
the
robust-ss-to-ts-casts
branch
from
a1f39bc to
b79c6c0
Compare
…a more robust pattern
strub
force-pushed
the
robust-ss-to-ts-casts
branch
from
b79c6c0 to
c4bdfcb
Compare
strub
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #850, which was caused by a typo in the old pattern where the left and right memory were in the wrong place. In the more robust pattern the left memory is always on the left and the right is always on the right, making it harder to make such mistakes.