Add choice_label support to CrudAutocompleteType#7521
Open
Amoifr wants to merge 2 commits intoEasyCorp:5.xfrom
Open
Add choice_label support to CrudAutocompleteType#7521Amoifr wants to merge 2 commits intoEasyCorp:5.xfrom
Amoifr wants to merge 2 commits intoEasyCorp:5.xfrom
Conversation
When using EntityFilter with autocomplete() and a custom choice_label, the form crashed because CrudAutocompleteType did not define choice_label as a valid option. Changes: - Add choice_label option to CrudAutocompleteType - Preserve user-defined choice_label in CrudAutocompleteSubscriber Fix EasyCorp#7462
Don't pass null choice_label explicitly to EntityType as it behaves differently than omitting the option in older Symfony versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using
EntityFilterwith->autocomplete()and a customchoice_label, the form crashed with:Root cause:
CrudAutocompleteTypedid not definechoice_labelas a valid option.Changes:
choice_labeloption toCrudAutocompleteType(supportsnull,string,callable,bool)CrudAutocompleteSubscriberto preserve user-definedchoice_labelinstead of overwriting itUsage example:
Test plan
Fix #7462