Conversation
🎉 Are we earthbuild yet?Great progress! You've reduced "earthly" occurrences by 22 (0.39%) 📈 Overall Progress
📁 Changes by file type:
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
Summary of ChangesHello @danielschlegel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request internalizes the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively removes the github.com/earthly/cloud-api dependency by internalizing the logstream package. The changes are well-structured and executed cleanly. The import paths have been updated across the codebase, and the build configuration in the Earthfile has been adjusted accordingly. The addition of a README.md in the new logstream package with instructions for regenerating the protobuf files is a great touch for maintainability. Overall, this is a solid improvement that reduces external dependencies. The changes look correct and ready to be merged.
This commit removes the cloud-api dependency by internalizing the logstream package that was the only component being used from that dependency. Changes: - Created local logstream package with proto definitions - Updated all imports from github.com/earthly/cloud-api/logstream to github.com/EarthBuild/earthbuild/logstream - Removed cloud-api from go.mod and go.sum - Updated Earthfile to remove CLOUD_API build logic - Applied gofumpt formatting to all modified files The logstream package provides the same Protocol Buffer types for build manifests, logging, and delta updates as the original cloud-api version. Fixes #221
23f3975 to
1b4fcf8
Compare
I've successfully fixed GitHub issue #221 by removing the unused
github.com/earthly/cloud-apidependency from the EarthBuild project. Here's what was done:Created local
logstreampackage (inearthbuild/logstream/):manifest.protoanddelta.protomanifest.pb.goanddelta.pb.goREADME.mdexplaining the packageUpdated all imports across the codebase (22 Go files):
github.com/earthly/cloud-api/logstream→github.com/EarthBuild/earthbuild/logstreamcmd/earthly/app/earthfile2llb/-logbus/and subdirectories -util/deltautil/-util/stringutil/Removed the dependency:
go.modgo.sumviago mod tidyUpdated build configuration:
CLOUD_APIargument and related build logic fromEarthfilelogstreamdirectory to build COPY commands✅ All existing tests pass successfully
✅ Project builds without errors (
go build ./...) ✅ No remaining references togithub.com/earthly/cloud-api✅ The logstream functionality is preserved with identical types and behaviorThe dependency has been completely removed while maintaining full backward compatibility of the logstream functionality!